Issue 1759263003: PNaCl: ExpandTls: Use C++11 range-based "for" loops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1759263003: PNaCl: ExpandTls: Use C++11 range-based "for" loops (Closed)

Created:
4 years, 9 months ago by Mark Seaborn

Modified:
4 years, 9 months ago

Reviewers:
Sean Klein

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm@master

Target Ref:
refs/heads/master

Visibility:
Public.

PNaCl: ExpandTls: Use C++11 range-based "for" loops Also use use_empty() rather than hasNUsesOrMore(1) since the former is clearer. BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351 TEST=test/Transforms/NaCl/expand-tls*.ll R=smklein@chromium.org Committed: https://chromium.googlesource.com/native_client/pnacl-llvm/+/cd98ed3e42a0463c61fd1ee3d6dadf6502c016eb

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -24 lines)			Patch
	M	lib/Transforms/NaCl/ExpandTls.cpp	View		4 chunks	+17 lines, -24 lines	0 comments	Download

Total messages: 5 (2 generated)

Mark Seaborn

4 years, 9 months ago (2016-03-04 19:10:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cd98ed3e42a0463c61fd1ee3d6dadf6502c016eb (presubmit successful).