Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 1759263002: Rename public/web/WebSocket things to WebPepperSocket. (Closed)

Created:
4 years, 9 months ago by esprehn
Modified:
4 years, 9 months ago
Reviewers:
haraken, dglazkov
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename public/web/WebSocket things to WebPepperSocket. These classes are only used by the PepperWebSocketHost, and blink does not intend to expose a low level WebSocket API for consumption in content. Lets rename the classes to reflect their non-general purpose. BUG=561879 Committed: https://crrev.com/042230c55004e7e7a408fb6b6b17fcc52ae1f5d7 Cr-Commit-Position: refs/heads/master@{#379191}

Patch Set 1 #

Patch Set 2 : typo. #

Patch Set 3 : woops. #

Patch Set 4 : woops. #

Patch Set 5 : more missed names. #

Patch Set 6 : more missed names. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -680 lines) Patch
M content/renderer/pepper/pepper_websocket_host.h View 4 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/pepper/pepper_websocket_host.cc View 4 chunks +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/web/WebPepperSocket.cpp View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/web/WebPepperSocketChannelClientProxy.h View 1 2 3 4 4 chunks +16 lines, -16 lines 0 comments Download
A + third_party/WebKit/Source/web/WebPepperSocketImpl.h View 1 2 3 4 4 chunks +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/web/WebPepperSocketImpl.cpp View 1 2 3 4 5 9 chunks +25 lines, -25 lines 0 comments Download
D third_party/WebKit/Source/web/WebSocket.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/Source/web/WebSocketChannelClientProxy.h View 1 2 3 4 1 chunk +0 lines, -78 lines 0 comments Download
D third_party/WebKit/Source/web/WebSocketImpl.h View 1 chunk +0 lines, -93 lines 0 comments Download
D third_party/WebKit/Source/web/WebSocketImpl.cpp View 1 chunk +0 lines, -207 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/public/web/WebPepperSocket.h View 4 chunks +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/public/web/WebPepperSocketClient.h View 3 chunks +5 lines, -5 lines 0 comments Download
D third_party/WebKit/public/web/WebSocket.h View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/WebKit/public/web/WebSocketClient.h View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 27 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759263002/1
4 years, 9 months ago (2016-03-03 19:23:06 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/125065)
4 years, 9 months ago (2016-03-03 19:39:55 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759263002/20001
4 years, 9 months ago (2016-03-03 21:57:33 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/102393) chromeos_daisy_chromium_compile_only_ng on ...
4 years, 9 months ago (2016-03-03 22:09:43 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759263002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759263002/60001
4 years, 9 months ago (2016-03-03 22:20:03 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759263002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759263002/80001
4 years, 9 months ago (2016-03-04 00:04:39 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759263002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759263002/100001
4 years, 9 months ago (2016-03-04 00:07:14 UTC) #16
esprehn
4 years, 9 months ago (2016-03-04 00:23:53 UTC) #18
dglazkov
lgtm
4 years, 9 months ago (2016-03-04 00:26:24 UTC) #19
haraken
LGTM
4 years, 9 months ago (2016-03-04 00:37:12 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759263002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759263002/100001
4 years, 9 months ago (2016-03-04 01:09:52 UTC) #24
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 9 months ago (2016-03-04 02:54:25 UTC) #25
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 02:55:31 UTC) #27
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/042230c55004e7e7a408fb6b6b17fcc52ae1f5d7
Cr-Commit-Position: refs/heads/master@{#379191}

Powered by Google App Engine
This is Rietveld 408576698