Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1759203002: fix status file (Closed)

Created:
4 years, 9 months ago by srdjan
Modified:
4 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, Bill Hesse
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : t #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/lib/lib.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
srdjan
4 years, 9 months ago (2016-03-03 17:32:26 UTC) #2
rmacnak
LGTM https://codereview.chromium.org/1759203002/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/1759203002/diff/1/tests/lib/lib.status#newcode346 tests/lib/lib.status:346: [ $compiler == dart2js && $host_checked && $unchecked] ...
4 years, 9 months ago (2016-03-03 17:33:10 UTC) #3
srdjan
Committed patchset #2 (id:20001) manually as 5c0a18d3bea7b08b932a917753ec14b25480838f (presubmit successful).
4 years, 9 months ago (2016-03-03 17:35:26 UTC) #5
srdjan
4 years, 8 months ago (2016-03-30 17:47:46 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1759203002/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/1759203002/diff/1/tests/lib/lib.status#newcod...
tests/lib/lib.status:346: [ $compiler == dart2js && $host_checked && $unchecked]
On 2016/03/03 17:33:10, rmacnak wrote:
> nit: space before right bracket

Done.

Powered by Google App Engine
This is Rietveld 408576698