Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 17592002: Add v8.log visualizer page. (Closed)

Created:
7 years, 6 months ago by Yang
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : 80 char limit for the html file #

Patch Set 3 : fix #

Patch Set 4 : small changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1149 lines, -561 lines) Patch
M tools/plot-timer-events View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
D tools/plot-timer-events.js View 1 2 3 1 chunk +0 lines, -510 lines 0 comments Download
M tools/presubmit.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
A tools/profviz/composer.js View 1 2 3 1 chunk +544 lines, -0 lines 0 comments Download
A + tools/profviz/profviz.css View 1 2 3 3 chunks +75 lines, -3 lines 0 comments Download
A tools/profviz/profviz.html View 1 2 3 1 chunk +131 lines, -0 lines 0 comments Download
A tools/profviz/profviz.js View 1 2 3 1 chunk +235 lines, -0 lines 0 comments Download
A + tools/profviz/stdio.js View 1 2 3 1 chunk +25 lines, -44 lines 0 comments Download
A tools/profviz/worker.js View 1 2 3 1 chunk +134 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
This change includes: - renaming of plot-timer-events.js to profviz/composer.js and refactoring its content to reuse ...
7 years, 6 months ago (2013-06-24 08:54:13 UTC) #1
Jakob Kummerow
LGTM, just nits. https://codereview.chromium.org/17592002/diff/1/tools/profviz/composer.js File tools/profviz/composer.js (right): https://codereview.chromium.org/17592002/diff/1/tools/profviz/composer.js#newcode49 tools/profviz/composer.js:49: var kTickHalfDuration = 0.5; // Duration ...
7 years, 5 months ago (2013-06-24 11:03:33 UTC) #2
Yang
On 2013/06/24 11:03:33, Jakob wrote: > LGTM, just nits. > > https://codereview.chromium.org/17592002/diff/1/tools/profviz/composer.js > File tools/profviz/composer.js ...
7 years, 5 months ago (2013-06-24 11:17:18 UTC) #3
Yang
7 years, 5 months ago (2013-06-24 13:26:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r15292 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698