Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1759173002: [Layout API] Create api/LayoutLIItem and use it in html/HTMLLIElement (Closed)

Created:
4 years, 9 months ago by pilgrim_google
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, dgrogan, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Create api/LayoutLIItem and use it in html/HTMLLIElement This adds LayoutLIItem as a descendant of LayoutBoxItem (there is currently no LayoutBlockFlowItem) in the new layout API and provides 1 method, setNotInList(), which is used from HTMLLIElement::attach. There are no functional changes. BUG=499321 Committed: https://crrev.com/1170487b35230f1e8dc2bcc3aad6aa5d266ca3f3 Cr-Commit-Position: refs/heads/master@{#379093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -2 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLIElement.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutItem.h View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/api/LayoutLIItem.h View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pilgrim_google
4 years, 9 months ago (2016-03-03 16:10:54 UTC) #2
leviw_travelin_and_unemployed
lgtm
4 years, 9 months ago (2016-03-03 20:20:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759173002/1
4 years, 9 months ago (2016-03-03 20:21:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 21:30:30 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 21:31:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1170487b35230f1e8dc2bcc3aad6aa5d266ca3f3
Cr-Commit-Position: refs/heads/master@{#379093}

Powered by Google App Engine
This is Rietveld 408576698