Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 175913002: Fix error on iOS native interface (Closed)

Created:
6 years, 10 months ago by egdaniel
Modified:
6 years, 10 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix error on iOS native interface NOTREECHECK=True NOTRY=True TBR=bsalomon@google.com BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13546

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/gl/iOS/GrGLCreateNativeInterface_iOS.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 10 months ago (2014-02-21 22:19:52 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 22:20:01 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-21 22:20:02 UTC) #3
egdaniel
6 years, 10 months ago (2014-02-21 22:20:35 UTC) #4
bsalomon
On 2014/02/21 22:20:35, egdaniel wrote: lgtm
6 years, 10 months ago (2014-02-21 22:20:47 UTC) #5
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 10 months ago (2014-02-21 22:21:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/175913002/1
6 years, 10 months ago (2014-02-21 22:21:13 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 22:21:19 UTC) #8
Message was sent while issue was closed. 
Change committed as 13546

Powered by Google App Engine
This is Rietveld 408576698