content/browser/frame_host/render_frame_host_impl.h - Issue 1759123002: Ensure RenderFrameHost & NavigationHandle are not destroyed during commit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1759123002: Ensure RenderFrameHost & NavigationHandle are not destroyed during commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigator_impl.cc ('K') | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index 35195ba830e8ee03acb27607c324e071e9b4e0cf..d66dd1b5404512f5629a4123c4fa208653980709 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -942,6 +942,11 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost,

// called (no pending instance should be set).

bool should_reuse_web_ui_;

+ // True if the RenderFrameHost is in the process of committing a navigation.

+ // This is temporary to help pinpoint the cause of crbug.com/589365.

+ // TODO(clamy): Remove once enough data has been gathered.

+ bool is_in_commit_;

// NOTE: This must be the last member.

base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;