Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 1759123002: Ensure RenderFrameHost & NavigationHandle are not destroyed during commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index ba4190dd0c8206bd0c164e8f500b9123bda32435..42c2e8525aee840bf392c79286213c781f59154d 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -206,6 +206,10 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
bool same_page,
RenderFrameHostImpl* render_frame_host);
+ // TODO(clamy): Remove this once enough data has been gathered for
+ // crbug.com/589365.
+ void set_is_in_commit(bool is_in_commit) { is_in_commit_ = is_in_commit; }
+
private:
friend class NavigationHandleImplTest;
@@ -287,6 +291,12 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
// corresponding ServiceWorkerNetworkProvider is created in the renderer.
scoped_ptr<ServiceWorkerNavigationHandle> service_worker_handle_;
+ // True if the RenderFrameHost that owns the NavigationHandle is in the
+ // process of committing a navigation. This is temporary to help pinpoint
+ // the cause of crbug.com/589365.
+ // TODO(clamy): Remove once enough data has been gathered.
+ bool is_in_commit_;
+
DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl);
};
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_handle_impl.cc » ('j') | content/browser/frame_host/navigator_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698