Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: Source/bindings/scripts/preprocess_idls.py

Issue 17591008: Commented IDL implements statements should not generate code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/tests/idls/TestObject.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/preprocess_idls.py
diff --git a/Source/bindings/scripts/preprocess_idls.py b/Source/bindings/scripts/preprocess_idls.py
index 4603df304141bfefa328e5ce83f7b8f053ff19ab..2e330445461f5595435419c2f1e616644eb3eb35 100644
--- a/Source/bindings/scripts/preprocess_idls.py
+++ b/Source/bindings/scripts/preprocess_idls.py
@@ -74,7 +74,7 @@ def get_partial_interface_name_from_idl(file_contents):
# http://www.w3.org/TR/WebIDL/#idl-implements-statements
def get_implemented_interfaces_from_idl(file_contents, interface_name):
implemented_interfaces = []
- for match in re.finditer(r'(\w+)\s+implements\s+(\w+)\s*;', file_contents):
+ for match in re.finditer(r'^\s*(\w+)\s+implements\s+(\w+)\s*;', file_contents, re.MULTILINE):
# identifier-A must be the current interface
assert match.group(1) == interface_name, \
"Identifier on the left of the 'implements' statement should be %s in %s.idl, but found %s" % (interface_name, interface_name, match.group(1))
« no previous file with comments | « no previous file | Source/bindings/tests/idls/TestObject.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698