Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 175903002: Re-add snap-back behavior (Chrome side) (Closed)

Created:
6 years, 10 months ago by Peter Kasting
Modified:
6 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

After Aura copied the original Linux scrollbar behvaior, it never got updated with Windows-specific native behaviors from ScrollbarThemeWin.cpp: * Snap the scrollbar back to its drag origin when dragged too far off the track. This code matches the old code we had for years and also matches my Win 7 native scrollbars pixel-for-pixel. * Don't jump the scroll thumb to the mouse cursor on a middle-click, only on a shift-click. Middle-click must be a GTK-ism. This is the Chrome side of the changes to re-add this behavior. BUG=337919 TEST=Drag a scroll thumb to somewhere in the track, then without releasing, move the mouse far away from the track. The scroll thumb should snap back to the scroll origin. R=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254305

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -20 lines) Patch
M content/content_renderer.gypi View 1 2 3 4 5 6 2 chunks +11 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 6 3 chunks +17 lines, -11 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 3 4 5 6 4 chunks +24 lines, -9 lines 0 comments Download
A content/renderer/webscrollbarbehavior_impl_gtkoraura.h View 1 4 1 chunk +26 lines, -0 lines 0 comments Download
A content/renderer/webscrollbarbehavior_impl_gtkoraura.cc View 1 1 chunk +52 lines, -0 lines 0 comments Download
A content/renderer/webscrollbarbehavior_impl_mac.h View 1 1 chunk +33 lines, -0 lines 0 comments Download
A content/renderer/webscrollbarbehavior_impl_mac.mm View 1 2 3 4 5 6 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
Avi, can you review this? The Blink side is at https://codereview.chromium.org/151483008/ for reference. You implemented ...
6 years, 10 months ago (2014-02-24 23:57:58 UTC) #1
Avi (use Gerrit)
lgtm https://codereview.chromium.org/175903002/diff/80001/content/content_renderer.gypi File content/content_renderer.gypi (right): https://codereview.chromium.org/175903002/diff/80001/content/content_renderer.gypi#newcode563 content/content_renderer.gypi:563: 'renderer/webscrollbarbehavior_impl_gtkoraura.h', Huh. Do we do this anywhere else? ...
6 years, 10 months ago (2014-02-25 03:44:31 UTC) #2
Peter Kasting
https://codereview.chromium.org/175903002/diff/80001/content/content_renderer.gypi File content/content_renderer.gypi (right): https://codereview.chromium.org/175903002/diff/80001/content/content_renderer.gypi#newcode563 content/content_renderer.gypi:563: 'renderer/webscrollbarbehavior_impl_gtkoraura.h', On 2014/02/25 03:44:31, Avi wrote: > Huh. Do ...
6 years, 10 months ago (2014-02-25 06:10:02 UTC) #3
Peter Kasting
6 years, 9 months ago (2014-03-01 01:06:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #7 manually as r254305 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698