services/ui/view_manager/view_registry.cc - Issue 1759003002: Mozart: Correctly unregister views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/view_manager/view_registry.cc

Issue 1759003002: Mozart: Correctly unregister views. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/ui/view_manager/view_registry.cc

diff --git a/services/ui/view_manager/view_registry.cc b/services/ui/view_manager/view_registry.cc

index 410537ef0e69a613a74d14a9e9ea6f5da47f6fbf..4868d0dd285036edeb36833f92e07a683d842cd5 100644

--- a/services/ui/view_manager/view_registry.cc

+++ b/services/ui/view_manager/view_registry.cc

@@ -459,8 +459,9 @@ void ViewRegistry::TransferOrUnregisterViewStub(

void ViewRegistry::UnregisterViewStub(std::unique_ptr<ViewStub> view_stub) {

DCHECK(view_stub);

- if (view_stub->state())

- UnregisterView(view_stub->state());

+ ViewState* view_state = view_stub->ReleaseView();

+ if (view_state)

+ UnregisterView(view_state);

}

void ViewRegistry::SetLayout(ViewStub* view_stub,

« no previous file with comments | « no previous file | no next file » | no next file with comments »