Issue 1759003002: Mozart: Correctly unregister views.

Issue 1759003002: Mozart: Correctly unregister views. (Closed)

Created:
4 years, 9 months ago by jeffbrown

Modified:
4 years, 9 months ago

Reviewers:
abarth

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Mozart: Correctly unregister views. We need to tell ViewStub that we're releasing the view before we actually unregister. This was caught by a safety check in ViewStub's destructor to ensure everything the ViewStub owns is cleaned up properly before the ViewStub itself is dropped on the floor. BUG= R=abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/005a135869f8b04f13ecae5823a6132c23e8895f

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	services/ui/view_manager/view_registry.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

abarth

LGTM As discussed in person, this is a signal that we should start unit testing ...

4 years, 9 months ago (2016-03-03 02:21:20 UTC) #3

jeffbrown

4 years, 9 months ago (2016-03-03 21:01:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
005a135869f8b04f13ecae5823a6132c23e8895f (presubmit successful).