Issue 17590005: Drop (mis)use of HPhase in full code gen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17590005: Drop (mis)use of HPhase in full code gen. (Closed)

Created:
7 years, 6 months ago by Benedikt Meurer

Modified:
7 years, 6 months ago

Reviewers:
danno

CC:
Toon Verwaest

Base URL:
git@github.com:v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Drop (mis)use of HPhase in full code gen. The full code generator is not a proper Hydrogen phase. The full code gen ticks are tracked in a special member of HStatistics, so HPhase is most probably misused at this point. R=danno@chromium.org BUG= Committed: 15291

Patch Set 1 #

Patch Set 2 : Fix GCC warning about uninitialized start_ticks variable. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -19 lines)			Patch
M	src/compiler.cc	View	1	2 chunks	+8 lines, -1 line	0 comments	Download
M	src/hydrogen.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/hydrogen.cc	View		1 chunk	+9 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

7 years, 6 months ago (2013-06-24 13:25:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r15291 (presubmit successful).

Expand Messages | Collapse Messages