chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js - Issue 1758973002: MD Settings: Creating a <settings-dialog> element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

Issue 1758973002: MD Settings: Creating a <settings-dialog> element. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove extra blank line Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html ('k') | chrome/browser/resources/settings/settings_dialog.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js b/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

index 10e4e29fe21f9751c80ca9edf0f5f4f0f8675ce9..06eb4ded137f4ff57d0bc7f893b522b17dee6505 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

@@ -68,6 +68,10 @@ Polymer({

loadTimeData.getString('searchEnginesAddSearchEngine');

this.actionButtonText_ = loadTimeData.getString('add');

}

+ this.addEventListener('iron-overlay-canceled', function() {

+ this.browserProxy_.searchEngineEditCancelled();

+ }.bind(this));

/** @override */

@@ -80,8 +84,7 @@ Polymer({

/** @private */

cancel_: function() {

- this.browserProxy_.searchEngineEditCancelled();

- this.$.dialog.close();

+ this.$.dialog.cancel();

/** @private */