chrome/browser/resources/settings/settings_dialog.html - Issue 1758973002: MD Settings: Creating a <settings-dialog> element.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_dialog.html

Issue 1758973002: MD Settings: Creating a <settings-dialog> element. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolve conflicts. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js ('k') | chrome/browser/resources/settings/settings_dialog.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer_config.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog-behavior/p aper-dialog-behavior.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog-behavior/p aper-dialog-shared-styles.html">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

	6 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	7 <link rel="import" href="chrome://md-settings/settings_dialog_css.html">

	8

	9 <dom-module id="settings-dialog">

	10 <template>

	11 <style include="paper-dialog-shared-styles"></style>

	12 <style include="settings-dialog-css"></style>
	dschuyler 2016/03/04 02:29:48 If this is the only place that should use settings If this is the only place that should use settings-dialog-css let's pull that content here and remove that file. dpapad 2016/03/04 02:45:58 Done. Show quoted text On 2016/03/04 at 02:29:48, dschuyler wrote: > If this is the only place that should use settings-dialog-css > let's pull that content here and remove that file. Done.
	13 <div class="dialog-content">

	14 <div class="top-row">

	15 <content select=".title"></content>

	16 <paper-icon-button icon="clear" on-tap="cancel" id="close">

	17 </paper-icon-button>

	18 </div>

	19 <div class="body-content">

	20 <content select=".body"></content>

	21 <content select=".button-container"></content>

	22 </div>

	23 </div>

	24 <div class="footer-container">

	25 <content select=".footer"></content>

	26 </div>

	27 </template>

	28 <script src="settings_dialog.js"></script>

	29 </dom-module>

OLD	NEW