Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1758913004: MD History/Downloads: use MD-specific text defaults (like other MD UIs) (Closed)

Created:
4 years, 9 months ago by Dan Beam
Modified:
4 years, 9 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, asanka, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org, tsergeant
Base URL:
https://chromium.googlesource.com/chromium/src.git@dschuyler-patch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History/Downloads: use MD-specific text defaults (like other MD UIs) R=dschuyler@chromium.org BUG=589630 Committed: https://crrev.com/4ed0d4123ed0f9a2defbe13069880f26dd9de3ab Cr-Commit-Position: refs/heads/master@{#379358}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -60 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 chunk +0 lines, -19 lines 2 comments Download
M chrome/browser/resources/md_downloads/downloads.html View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanize.py View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 2 chunks +1 line, -33 lines 0 comments Download
M chrome/browser/resources/md_history/history.html View 2 chunks +1 line, -4 lines 0 comments Download

Depends on Patchset:

Issue 1754803005 Patch 1

Messages

Total messages: 12 (5 generated)
Dan Beam
4 years, 9 months ago (2016-03-04 02:03:22 UTC) #3
dschuyler
https://codereview.chromium.org/1758913004/diff/1/chrome/browser/resources/md_downloads/crisper.js File chrome/browser/resources/md_downloads/crisper.js (left): https://codereview.chromium.org/1758913004/diff/1/chrome/browser/resources/md_downloads/crisper.js#oldcode1082 chrome/browser/resources/md_downloads/crisper.js:1082: /** This change seems unlike the other changes in ...
4 years, 9 months ago (2016-03-04 19:16:39 UTC) #4
Dan Beam
https://codereview.chromium.org/1758913004/diff/1/chrome/browser/resources/md_downloads/crisper.js File chrome/browser/resources/md_downloads/crisper.js (left): https://codereview.chromium.org/1758913004/diff/1/chrome/browser/resources/md_downloads/crisper.js#oldcode1082 chrome/browser/resources/md_downloads/crisper.js:1082: /** On 2016/03/04 19:16:38, dschuyler wrote: > This change ...
4 years, 9 months ago (2016-03-04 20:23:16 UTC) #5
dschuyler
lgtm
4 years, 9 months ago (2016-03-04 20:24:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758913004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758913004/1
4 years, 9 months ago (2016-03-04 20:30:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 21:21:28 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 21:23:00 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4ed0d4123ed0f9a2defbe13069880f26dd9de3ab
Cr-Commit-Position: refs/heads/master@{#379358}

Powered by Google App Engine
This is Rietveld 408576698