Add instantiate method on ParameterizedType and InterfaceType.

Add instantiate method on ParameterizedType and InterfaceType,
and deprecate the old substitute4 in favor of instantiate.

BUG=
R=brianwilkerson@google.com, jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/7d2976c7d5829b55f3e29d14a5c5fff0584ee038

[Leaf, 2016-03-02 21:30:50]

Description was changed from

==========
Add instantiate method on ParameterizedType and InterfaceType.

BUG=
==========

to

==========
Add instantiate method on ParameterizedType and InterfaceType,
and deprecate the old substitute4 in favor of instantiate.

BUG=
==========

[Leaf, 2016-03-02 21:30:51]

leafp@google.com changed reviewers:
+ brianwilkerson@google.com, jmesserly@google.com

[Leaf, 2016-03-02 21:33:50]

This adds instantiate on the public ParameterizedType and InterfaceType APIs,
with corresponding implementations.  substitute4 is deprecated, and all uses of
it are replaced with instantiate.  This addresses the first (easy) part of
https://github.com/dart-lang/sdk/issues/25378 .

This should be non-breaking given the restrictions on implementing/extending the
DartType subclasses, but adding Brian in case there are any concerns.

[Jennifer Messerly, 2016-03-02 21:40:12]

lgtm

[Brian Wilkerson, 2016-03-02 21:54:52]

LGTM

https://codereview.chromium.org/1758913002/diff/1/pkg/analyzer/lib/dart/eleme...
File pkg/analyzer/lib/dart/element/type.dart (right):

https://codereview.chromium.org/1758913002/diff/1/pkg/analyzer/lib/dart/eleme...
pkg/analyzer/lib/dart/element/type.dart:247: * [argumentTypes] for this
function's bound type parameters.
I generally don't repeat doc comments when overriding.

https://codereview.chromium.org/1758913002/diff/1/pkg/analyzer/lib/dart/eleme...
pkg/analyzer/lib/dart/element/type.dart:671: * we ask for the field type we will
get`S`.
Missing space after 'get'.

https://codereview.chromium.org/1758913002/diff/1/pkg/analyzer/lib/dart/eleme...
pkg/analyzer/lib/dart/element/type.dart:693: * [argumentTypes] for this types
bound type parameters.
"types" --> "type's"

https://codereview.chromium.org/1758913002/diff/1/pkg/analyzer/lib/dart/eleme...
pkg/analyzer/lib/dart/element/type.dart:695: DartType instantiate(List<DartType>
argumentTypes);
The return type could be tightened to ParameterizedType. (Or we could make
ParameterizedType generic and use the type parameter here. That would make the
code harder to read, but allow us to get rid of the overrides in the subtypes.)

[Leaf, 2016-03-02 23:06:02]

https://codereview.chromium.org/1758913002/diff/1/pkg/analyzer/lib/dart/eleme...
File pkg/analyzer/lib/dart/element/type.dart (right):

https://codereview.chromium.org/1758913002/diff/1/pkg/analyzer/lib/dart/eleme...
pkg/analyzer/lib/dart/element/type.dart:247: * [argumentTypes] for this
function's bound type parameters.
On 2016/03/02 21:54:52, Brian Wilkerson wrote:
> I generally don't repeat doc comments when overriding.

Done.

https://codereview.chromium.org/1758913002/diff/1/pkg/analyzer/lib/dart/eleme...
pkg/analyzer/lib/dart/element/type.dart:671: * we ask for the field type we will
get`S`.
On 2016/03/02 21:54:52, Brian Wilkerson wrote:
> Missing space after 'get'.

Done.

https://codereview.chromium.org/1758913002/diff/1/pkg/analyzer/lib/dart/eleme...
pkg/analyzer/lib/dart/element/type.dart:693: * [argumentTypes] for this types
bound type parameters.
On 2016/03/02 21:54:52, Brian Wilkerson wrote:
> "types" --> "type's"

Done.

https://codereview.chromium.org/1758913002/diff/1/pkg/analyzer/lib/dart/eleme...
pkg/analyzer/lib/dart/element/type.dart:695: DartType instantiate(List<DartType>
argumentTypes);
On 2016/03/02 21:54:52, Brian Wilkerson wrote:
> The return type could be tightened to ParameterizedType. (Or we could make
> ParameterizedType generic and use the type parameter here. That would make the
> code harder to read, but allow us to get rid of the overrides in the
subtypes.)

Done.

[Leaf, 2016-03-02 23:06:43]

Description was changed from

==========
Add instantiate method on ParameterizedType and InterfaceType,
and deprecate the old substitute4 in favor of instantiate.

BUG=
==========

to

==========
Add instantiate method on ParameterizedType and InterfaceType,
and deprecate the old substitute4 in favor of instantiate.

BUG=
R=brianwilkerson@google.com, jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7d2976c7d5829b55f3e29d14a5c5fff0584ee038
==========

[Leaf, 2016-03-02 23:06:44]

Committed patchset #2 (id:20001) manually as
7d2976c7d5829b55f3e29d14a5c5fff0584ee038 (presubmit successful).