Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: chrome/browser/media/webrtc_log_uploader.h

Issue 17589014: Write a log list for uploaded WebRTC logs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Using ReadFileToString and WriteFile instead of platform file. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/media/webrtc_log_uploader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc_log_uploader.h
diff --git a/chrome/browser/media/webrtc_log_uploader.h b/chrome/browser/media/webrtc_log_uploader.h
index 2833a862807c7e6418f1a27ff138029659664fa1..ecd53d645198066b3fa3e0e0b89de35ebd189622 100644
--- a/chrome/browser/media/webrtc_log_uploader.h
+++ b/chrome/browser/media/webrtc_log_uploader.h
@@ -9,6 +9,7 @@
#include <vector>
#include "base/basictypes.h"
+#include "base/gtest_prod_util.h"
#include "base/memory/ref_counted.h"
#include "base/platform_file.h"
#include "net/url_request/url_fetcher_delegate.h"
@@ -27,8 +28,9 @@ typedef struct z_stream_s z_stream;
class WebRtcLogURLRequestContextGetter;
// WebRtcLogUploader uploads WebRTC logs, keeps count of how many logs have
-// been started and denies further logs if a limit is reached. There must only
-// be one object of this type.
+// been started and denies further logs if a limit is reached. It also adds
+// the timestamp and report ID of the uploded log to a text file. There must
+// only be one object of this type.
class WebRtcLogUploader : public net::URLFetcherDelegate {
public:
WebRtcLogUploader();
@@ -60,6 +62,9 @@ class WebRtcLogUploader : public net::URLFetcherDelegate {
}
private:
+ FRIEND_TEST_ALL_PREFIXES(WebRtcLogUploaderTest,
+ AddUploadedLogInfoToUploadListFile);
+
// Sets up a multipart body to be uploaded. The body is produced according
// to RFC 2046.
void SetupMultipart(std::string* post_data, uint8* log_buffer,
@@ -73,7 +78,22 @@ class WebRtcLogUploader : public net::URLFetcherDelegate {
void ResizeForNextOutput(std::string* post_data, z_stream* stream);
void DecreaseLogCount();
+ // Append information (time and report ID) about this uploaded log to a log
+ // list file, limited to |kLogListLimitLines| entries. This list is used for
+ // viewing the uploaded logs under chrome://webrtc-logs, see
+ // WebRtcLogUploadList. The list has the format
+ // time,id
+ // time,id
+ // etc.
+ // where each line represents an uploaded log and "time" is Unix time.
+ void AddUploadedLogInfoToUploadListFile(const std::string& report_id);
+
+ void SetUploadPathForTesting(const base::FilePath& path) {
+ upload_list_path_ = path;
+ }
+
int log_count_;
+ base::FilePath upload_list_path_;
// For testing purposes, see OverrideUploadWithBufferForTesting. Only accessed
// on the FILE thread.
« no previous file with comments | « no previous file | chrome/browser/media/webrtc_log_uploader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698