Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 17589013: Introduce Unsigned32 and RegExp types (Closed)

Created:
7 years, 6 months ago by rossberg
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Introduce Unsigned32 and RegExp types Also, renamed Integer31 back to Smi, and Integer32 to Signed32. R=jkummerow@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=15332

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -32 lines) Patch
M src/hydrogen.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/ic.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/types.h View 1 6 chunks +27 lines, -18 lines 0 comments Download
M src/types.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M test/cctest/test-types.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rossberg
7 years, 6 months ago (2013-06-24 14:46:17 UTC) #1
Jakob Kummerow
LGTM with a nit. https://codereview.chromium.org/17589013/diff/1/src/types.h File src/types.h (right): https://codereview.chromium.org/17589013/diff/1/src/types.h#newcode52 src/types.h:52: // Smi < Signed32 strictly ...
7 years, 6 months ago (2013-06-24 15:12:11 UTC) #2
Vyacheslav Egorov (Google)
DBC: Smi on x64 is a Signed32. How does it fit with naming?
7 years, 6 months ago (2013-06-24 15:14:16 UTC) #3
Jakob Kummerow
On 2013/06/24 15:14:16, Vyacheslav Egorov (Google) wrote: > DBC: Smi on x64 is a Signed32. ...
7 years, 6 months ago (2013-06-24 15:18:52 UTC) #4
rossberg
https://codereview.chromium.org/17589013/diff/1/src/types.h File src/types.h (right): https://codereview.chromium.org/17589013/diff/1/src/types.h#newcode52 src/types.h:52: // Smi < Signed32 On 2013/06/24 15:12:11, Jakob wrote: ...
7 years, 6 months ago (2013-06-25 06:21:51 UTC) #5
rossberg
7 years, 6 months ago (2013-06-26 09:52:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r15332 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698