Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 17589009: Do not use deprecated MakeWeak in d8. (Closed)

Created:
7 years, 6 months ago by Yang
Modified:
7 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Do not use deprecated MakeWeak in d8. R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15290

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/d8.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 6 months ago (2013-06-24 11:36:56 UTC) #1
Sven Panne
lgtm
7 years, 6 months ago (2013-06-24 13:03:58 UTC) #2
Yang
7 years, 6 months ago (2013-06-24 13:15:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15290 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698