Certificate Transparency: Ensure timestamps over 32 bit are handled correctly.

net/cert/ct_log_response_parser_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/ct_log_response_parser.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/json/json_reader.h"
@@ skipping 77 matching lines @@
   base::Base64Decode(
       base::StringPiece("/WHFMgXtI/umKKuACJIN0Bb73TcILm9WkeU6qszvoA==\n"),
       &too_short_hash);
   scoped_ptr<base::Value> too_short_hash_json =
       ParseJson(CreateSignedTreeHeadJsonString(
           1 /* tree_size */, 123456u /* timestamp */,
           GetSampleSTHSHA256RootHash(), too_short_hash));
   ASSERT_FALSE(FillSignedTreeHead(*too_short_hash_json.get(), &tree_head));
 }
 
+TEST(CTLogResponseParserTest, ParsesJsonSTHWithLargeTimestamp) {
+  SignedTreeHead tree_head;
+
+  scoped_ptr<base::Value> large_timestamp_json =
+      ParseJson(CreateSignedTreeHeadJsonString(
+          100, 1L << 34, GetSampleSTHSHA256RootHash(),

[davidben, 2016/03/02 17:30:39]

1L -> INT64_C(1) ?

[Ryan Sleevi, 2016/03/02 19:03:22]

Yes, this is needed

[Eran Messeri, 2016/03/04 11:28:30]

Done.

+          GetSampleSTHTreeHeadSignature()));
+
+  ASSERT_TRUE(FillSignedTreeHead(*large_timestamp_json.get(), &tree_head));
+
+  base::Time expected_time =
+      base::Time::UnixEpoch() +
+      base::TimeDelta::FromMilliseconds(INT64_C(1) << 34);
+
+  EXPECT_EQ(tree_head.timestamp, expected_time);
+}
+
 TEST(CTLogResponseParserTest, ParsesConsistencyProofSuccessfully) {
   std::string first(32, 'a');
   std::string second(32, 'b');
   std::string third(32, 'c');
 
   std::vector<std::string> raw_nodes;
   raw_nodes.push_back(first);
   raw_nodes.push_back(second);
   raw_nodes.push_back(third);
   scoped_ptr<base::Value> sample_consistency_proof =
@@ skipping 30 matching lines @@
   std::vector<std::string> output;
 
   scoped_ptr<base::Value> badly_encoded =
       ParseJson(std::string("{\"consistency\": [], \"somethingelse\": 3}"));
   EXPECT_TRUE(FillConsistencyProof(*badly_encoded.get(), &output));
 }
 
 }  // namespace ct
 
 }  // namespace net