Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: dart/sdk/lib/_internal/compiler/implementation/dart2js.dart

Issue 17588005: Warn about overriding operator== but not hashCode. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Update comments (according to my dictionary whitelist is a word). Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.cmdline; 5 library dart2js.cmdline;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:collection' show Queue, LinkedHashMap; 8 import 'dart:collection' show Queue, LinkedHashMap;
9 import 'dart:io'; 9 import 'dart:io';
10 import 'dart:utf'; 10 import 'dart:utf';
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 } 220 }
221 } 221 }
222 222
223 List<String> arguments = <String>[]; 223 List<String> arguments = <String>[];
224 List<OptionHandler> handlers = <OptionHandler>[ 224 List<OptionHandler> handlers = <OptionHandler>[
225 new OptionHandler('-[chv?]+', handleShortOptions), 225 new OptionHandler('-[chv?]+', handleShortOptions),
226 new OptionHandler('--throw-on-error', 226 new OptionHandler('--throw-on-error',
227 (_) => diagnosticHandler.throwOnError = true), 227 (_) => diagnosticHandler.throwOnError = true),
228 new OptionHandler('--suppress-warnings', 228 new OptionHandler('--suppress-warnings',
229 (_) => diagnosticHandler.showWarnings = false), 229 (_) => diagnosticHandler.showWarnings = false),
230 new OptionHandler('--suppress-hints',
231 (_) => diagnosticHandler.showHints = false),
230 new OptionHandler('--output-type=dart|--output-type=js', setOutputType), 232 new OptionHandler('--output-type=dart|--output-type=js', setOutputType),
231 new OptionHandler('--verbose', setVerbose), 233 new OptionHandler('--verbose', setVerbose),
232 new OptionHandler('--version', (_) => wantVersion = true), 234 new OptionHandler('--version', (_) => wantVersion = true),
233 new OptionHandler('--library-root=.+', setLibraryRoot), 235 new OptionHandler('--library-root=.+', setLibraryRoot),
234 new OptionHandler('--out=.+|-o.*', setOutput, multipleArguments: true), 236 new OptionHandler('--out=.+|-o.*', setOutput, multipleArguments: true),
235 new OptionHandler('--allow-mock-compilation', passThrough), 237 new OptionHandler('--allow-mock-compilation', passThrough),
236 new OptionHandler('--minify', passThrough), 238 new OptionHandler('--minify', passThrough),
237 new OptionHandler('--force-strip=.*', setStrip), 239 new OptionHandler('--force-strip=.*', setStrip),
238 // TODO(ahe): Remove the --no-colors option. 240 // TODO(ahe): Remove the --no-colors option.
239 new OptionHandler('--disable-diagnostic-colors', 241 new OptionHandler('--disable-diagnostic-colors',
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
472 --minify 474 --minify
473 Generate minified output. 475 Generate minified output.
474 476
475 --disallow-unsafe-eval 477 --disallow-unsafe-eval
476 Disable dynamic generation of code in the generated output. This is 478 Disable dynamic generation of code in the generated output. This is
477 necessary to satisfy CSP restrictions (see http://www.w3.org/TR/CSP/). 479 necessary to satisfy CSP restrictions (see http://www.w3.org/TR/CSP/).
478 480
479 --suppress-warnings 481 --suppress-warnings
480 Do not display any warnings. 482 Do not display any warnings.
481 483
484 --suppress-hints
485 Do not display any hints.
486
482 --enable-diagnostic-colors 487 --enable-diagnostic-colors
483 Add colors to diagnostic messages. 488 Add colors to diagnostic messages.
484 489
485 The following options are only used for compiler development and may 490 The following options are only used for compiler development and may
486 be removed in a future version: 491 be removed in a future version:
487 492
488 --output-type=dart 493 --output-type=dart
489 Output Dart code instead of JavaScript. 494 Output Dart code instead of JavaScript.
490 495
491 --throw-on-error 496 --throw-on-error
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
568 print(trace); 573 print(trace);
569 } finally { 574 } finally {
570 exit(253); // 253 is recognized as a crash by our test scripts. 575 exit(253); // 253 is recognized as a crash by our test scripts.
571 } 576 }
572 } 577 }
573 } 578 }
574 579
575 void main() { 580 void main() {
576 mainWithErrorHandler(new Options()); 581 mainWithErrorHandler(new Options());
577 } 582 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698