Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Side by Side Diff: dart/sdk/lib/_internal/compiler/compiler.dart

Issue 17588005: Warn about overriding operator== but not hashCode. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Update comments (according to my dictionary whitelist is a word). Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library compiler; 5 library compiler;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'implementation/apiimpl.dart'; 8 import 'implementation/apiimpl.dart';
9 9
10 // Unless explicitly allowed, passing [:null:] for any argument to the 10 // Unless explicitly allowed, passing [:null:] for any argument to the
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 130
131 /** 131 /**
132 * A warning as identified by the "Dart Programming Language 132 * A warning as identified by the "Dart Programming Language
133 * Specification" [http://www.dartlang.org/docs/spec/]. 133 * Specification" [http://www.dartlang.org/docs/spec/].
134 */ 134 */
135 static const Diagnostic WARNING = const Diagnostic(2, 'warning'); 135 static const Diagnostic WARNING = const Diagnostic(2, 'warning');
136 136
137 /** 137 /**
138 * Any other warning that is not covered by [WARNING]. 138 * Any other warning that is not covered by [WARNING].
139 */ 139 */
140 static const Diagnostic LINT = const Diagnostic(4, 'lint'); 140 static const Diagnostic HINT = const Diagnostic(4, 'hint');
141 141
142 /** 142 /**
143 * Informational messages. 143 * Informational messages.
144 */ 144 */
145 static const Diagnostic INFO = const Diagnostic(8, 'info'); 145 static const Diagnostic INFO = const Diagnostic(8, 'info');
146 146
147 /** 147 /**
148 * Informational messages that shouldn't be printed unless 148 * Informational messages that shouldn't be printed unless
149 * explicitly requested by the user of a compiler. 149 * explicitly requested by the user of a compiler.
150 */ 150 */
(...skipping 16 matching lines...) Expand all
167 final String name; 167 final String name;
168 168
169 /** 169 /**
170 * This constructor is not private to support user-defined 170 * This constructor is not private to support user-defined
171 * diagnostic kinds. 171 * diagnostic kinds.
172 */ 172 */
173 const Diagnostic(this.ordinal, this.name); 173 const Diagnostic(this.ordinal, this.name);
174 174
175 String toString() => name; 175 String toString() => name;
176 } 176 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698