Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: dart/tests/compiler/dart2js/analyze_api_test.dart

Issue 17588005: Warn about overriding operator== but not hashCode. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyze_api; 5 library analyze_api;
6 6
7 import "package:expect/expect.dart"; 7 import "package:expect/expect.dart";
8 import '../../../sdk/lib/_internal/libraries.dart'; 8 import '../../../sdk/lib/_internal/libraries.dart';
9 import 'analyze_helper.dart'; 9 import 'analyze_helper.dart';
10 10
11 /** 11 /**
12 * Map of white-listed warnings and errors. 12 * Map of white-listed warnings and errors.
13 * 13 *
14 * Only add a white-listing together with a bug report to dartbug.com and add 14 * Only add a white-listing together with a bug report to dartbug.com and add
15 * the bug issue number as a comment on the white-listing. 15 * the bug issue number as a comment on the white-listing.
16 * 16 *
17 * Use an identifiable suffix of the file uri as key. Use a fixed substring of 17 * Use an identifiable suffix of the file uri as key. Use a fixed substring of
18 * the error/warning message in the list of white-listings for each file. 18 * the error/warning message in the list of white-listings for each file.
19 */ 19 */
20 // TODO(johnniwinther): Support canonical URIs as keys and message kinds as 20 // TODO(johnniwinther): Support canonical URIs as keys and message kinds as
21 // values. 21 // values.
22 const Map<String, List<String>> WHITE_LIST = const { 22 const Map<String, List<String>> WHITE_LIST = const {
23 'path_observer.dart': 23 'path_observer.dart':
24 const ['Warning: Using "new Symbol"', // Issue 10565. 24 const ['Warning: Using "new Symbol"', // Issue 10565.
25 ], 25 ],
26 'sdk/lib/html/dart2js/html_dart2js.dart':
27 const ['Warning: The class "Rect" overrides "operator==", '
28 'but not "get hashCode".',
29 'Warning: The class "Point" overrides "operator==", '
30 'but not "get hashCode".',
31 'Warning: The class "_ClientRect" overrides "operator==", '
32 'but not "get hashCode".',
33 ],
26 }; 34 };
27 35
28 void main() { 36 void main() {
29 var uriList = new List<Uri>(); 37 var uriList = new List<Uri>();
30 LIBRARIES.forEach((String name, LibraryInfo info) { 38 LIBRARIES.forEach((String name, LibraryInfo info) {
31 if (info.documented) { 39 if (info.documented) {
32 uriList.add(new Uri(scheme: 'dart', path: name)); 40 uriList.add(new Uri(scheme: 'dart', path: name));
33 } 41 }
34 }); 42 });
35 analyze(uriList, WHITE_LIST); 43 analyze(uriList, WHITE_LIST);
36 } 44 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698