Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.h

Issue 1758783002: Revert of Reduce ActiveDOMObjects from modules/mediastream/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.h
diff --git a/third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.h b/third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.h
index 2cb9276ed60e9ce03005469a42cdff26b4a2d054..8f4354ad7da4b5531c81698526b3f146cd366f71 100644
--- a/third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.h
+++ b/third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.h
@@ -27,7 +27,7 @@
#define MediaDevicesRequest_h
#include "bindings/core/v8/ScriptPromise.h"
-#include "core/dom/ContextLifecycleObserver.h"
+#include "core/dom/ActiveDOMObject.h"
#include "modules/ModulesExport.h"
#include "modules/mediastream/MediaDeviceInfo.h"
#include "platform/heap/Handle.h"
@@ -41,11 +41,11 @@
class ScriptState;
class ScriptPromiseResolver;
-// TODO(haraken): Make this GarbageCollected once the WillBe type is removed.
-class MODULES_EXPORT MediaDevicesRequest final : public GarbageCollectedFinalized<MediaDevicesRequest>, public ContextLifecycleObserver {
+class MODULES_EXPORT MediaDevicesRequest final : public GarbageCollectedFinalized<MediaDevicesRequest>, public ActiveDOMObject {
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MediaDevicesRequest);
public:
static MediaDevicesRequest* create(ScriptState*, UserMediaController*);
+ ~MediaDevicesRequest() override;
Document* ownerDocument();
@@ -53,7 +53,8 @@
void succeed(const MediaDeviceInfoVector&);
- void contextDestroyed() override;
+ // ActiveDOMObject
+ void stop() override;
DECLARE_VIRTUAL_TRACE();

Powered by Google App Engine
This is Rietveld 408576698