Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1758743003: Revert of Pull and build shaderc rather than use checked in lib/header (Closed)

Created:
4 years, 9 months ago by borenet
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@depsos
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Pull and build shaderc rather than use checked in lib/header (patchset #7 id:120001 of https://codereview.chromium.org/1760493003/ ) Reason for revert: `gclient sync` fails on bots after this change due to broken line endings in https://github.com/google/glslang/blob/master/Test/100.conf Original issue's description: > Pull and build shaderc rather than use checked in lib/header > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1760493003 > > Committed: https://skia.googlesource.com/skia/+/7d4490ecfa4d974003f675ef004e77f85ecfadd2 TBR=jvanverth@google.com,egdaniel@google.com,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -157 lines) Patch
M DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/gpu.gyp View 6 chunks +7 lines, -7 lines 0 comments Download
D gyp/shaderc.gyp View 1 chunk +0 lines, -63 lines 0 comments Download
A third_party/shaderc/Debug/shaderc_combined.lib View Binary file 0 comments Download
A third_party/shaderc/Release/shaderc_combined.lib View Binary file 0 comments Download
A third_party/shaderc/shaderc.h View 1 chunk +321 lines, -0 lines 0 comments Download
D tools/build_shaderc.py View 1 chunk +0 lines, -81 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
borenet
Created Revert of Pull and build shaderc rather than use checked in lib/header
4 years, 9 months ago (2016-03-03 12:58:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758743003/1
4 years, 9 months ago (2016-03-03 12:59:00 UTC) #2
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
4 years, 9 months ago (2016-03-03 12:59:08 UTC) #4
borenet
4 years, 9 months ago (2016-03-03 13:02:02 UTC) #5
On 2016/03/03 12:59:08, commit-bot: I haz the power wrote:
> Failed to request the patch to try. Please note that binary files are still
> unsupported at the moment, this is being worked on.
> 
> This could be a Rietveld flake (see http://crbug.com/401833), so if this CL
has
> no binary files, please re-check commit box.
> Thanks for your patience.
> 
> Transient error: Can't process patch for file
> third_party/shaderc/Release/shaderc_combined.lib.
> Binary file is empty. Maybe the file wasn't uploaded in the first place?

Landed manually:
https://skia.googlesource.com/skia/+/b5f0d40935feba474852c61622ee6fcb1db3727c

Powered by Google App Engine
This is Rietveld 408576698