Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1758733002: Move the ReferenceError check out of SetPropertyInternal. SetSuperProperty cannot need this case. (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move the ReferenceError check out of SetPropertyInternal. SetSuperProperty cannot need this case. BUG= Committed: https://crrev.com/bc18baf8ae43d4211f9f9ddd4b84b2bede7bf9b8 Cr-Commit-Position: refs/heads/master@{#34433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M src/objects.cc View 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-02 14:09:38 UTC) #2
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-02 14:19:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758733002/1
4 years, 9 months ago (2016-03-02 14:23:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 14:45:08 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 14:46:10 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bc18baf8ae43d4211f9f9ddd4b84b2bede7bf9b8
Cr-Commit-Position: refs/heads/master@{#34433}

Powered by Google App Engine
This is Rietveld 408576698