Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: runtime/vm/simulator_arm.cc

Issue 17587015: Allows exception object to be null in simarm and simmips. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/simulator_arm.cc
===================================================================
--- runtime/vm/simulator_arm.cc (revision 24343)
+++ runtime/vm/simulator_arm.cc (working copy)
@@ -3073,7 +3073,7 @@
set_register(PC, static_cast<int32_t>(pc));
set_register(SP, static_cast<int32_t>(sp));
set_register(FP, static_cast<int32_t>(fp));
- ASSERT(raw_exception != NULL);
+
regis 2013/06/24 17:30:47 My concern is that we trash register kExceptionObj
zra 2013/06/24 18:43:58 raw_exception == NULL means that someone threw the
set_register(kExceptionObjectReg, bit_cast<int32_t>(raw_exception));
if (raw_stacktrace != NULL) {
set_register(kStackTraceObjectReg, bit_cast<int32_t>(raw_stacktrace));

Powered by Google App Engine
This is Rietveld 408576698