Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: src/hydrogen.cc

Issue 17587008: Refactor Hydrogen environment liveness analysis into an HPhase. (Closed) Base URL: git@github.com:v8/v8.git@master
Patch Set: No need to allocate worklist and live bit vectors in zone Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/hydrogen-environment-liveness.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3944 matching lines...) Expand 10 before | Expand all | Expand 10 after
3955 // zero-valued constant in the graph together. 3955 // zero-valued constant in the graph together.
3956 // The constant is needed to make idef-based bounds check work: the pass 3956 // The constant is needed to make idef-based bounds check work: the pass
3957 // evaluates relations with "zero" and that zero cannot be created after GVN. 3957 // evaluates relations with "zero" and that zero cannot be created after GVN.
3958 GetConstant0(); 3958 GetConstant0();
3959 3959
3960 #ifdef DEBUG 3960 #ifdef DEBUG
3961 // Do a full verify after building the graph and computing dominators. 3961 // Do a full verify after building the graph and computing dominators.
3962 Verify(true); 3962 Verify(true);
3963 #endif 3963 #endif
3964 3964
3965 if (FLAG_analyze_environment_liveness) { 3965 if (FLAG_analyze_environment_liveness && maximum_environment_size() != 0) {
3966 EnvironmentSlotLivenessAnalyzer esla(this); 3966 Run<HEnvironmentLivenessAnalysisPhase>();
3967 esla.AnalyzeAndTrim();
3968 } 3967 }
3969 3968
3970 PropagateDeoptimizingMark(); 3969 PropagateDeoptimizingMark();
3971 if (!CheckConstPhiUses()) { 3970 if (!CheckConstPhiUses()) {
3972 *bailout_reason = SmartArrayPointer<char>(StrDup( 3971 *bailout_reason = SmartArrayPointer<char>(StrDup(
3973 "Unsupported phi use of const variable")); 3972 "Unsupported phi use of const variable"));
3974 return false; 3973 return false;
3975 } 3974 }
3976 EliminateRedundantPhis(); 3975 EliminateRedundantPhis();
3977 if (!CheckArgumentsPhiUses()) { 3976 if (!CheckArgumentsPhiUses()) {
(...skipping 7561 matching lines...) Expand 10 before | Expand all | Expand 10 after
11539 if (ShouldProduceTraceOutput()) { 11538 if (ShouldProduceTraceOutput()) {
11540 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 11539 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
11541 } 11540 }
11542 11541
11543 #ifdef DEBUG 11542 #ifdef DEBUG
11544 graph_->Verify(false); // No full verify. 11543 graph_->Verify(false); // No full verify.
11545 #endif 11544 #endif
11546 } 11545 }
11547 11546
11548 } } // namespace v8::internal 11547 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen-environment-liveness.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698