Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1758663002: Change syntax error message for illegal token. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Change syntax error message for illegal token. It used to say "Unexpected token ILLEGAL", now it says "Invalid or unexpected token". R=jkummerow@chromium.org BUG=chromium:257405 LOG=N Committed: https://crrev.com/879b617b19201c18c0351afb732aab10803da651 Cr-Commit-Position: refs/heads/master@{#34431}

Patch Set 1 #

Patch Set 2 : change webkit test expectations #

Total comments: 1

Patch Set 3 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M src/messages.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser-base.h View 1 2 2 chunks +4 lines, -8 lines 0 comments Download
M test/mjsunit/messages.js View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M test/webkit/fast/js/basic-strict-mode-expected.txt View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M test/webkit/fast/js/kde/parse-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
Yang
4 years, 9 months ago (2016-03-02 11:54:39 UTC) #1
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-02 12:57:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758663002/20001
4 years, 9 months ago (2016-03-02 13:03:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11774)
4 years, 9 months ago (2016-03-02 13:11:55 UTC) #7
rossberg
https://codereview.chromium.org/1758663002/diff/20001/src/messages.h File src/messages.h (right): https://codereview.chromium.org/1758663002/diff/20001/src/messages.h#newcode398 src/messages.h:398: T(InvalidSyntax, "Invalid syntax") \ How about: "Invalid or unexpected ...
4 years, 9 months ago (2016-03-02 13:36:19 UTC) #9
Yang
Addressed comment.
4 years, 9 months ago (2016-03-02 13:44:37 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758663002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758663002/40001
4 years, 9 months ago (2016-03-02 13:44:51 UTC) #13
rossberg
Thanks, lgtm
4 years, 9 months ago (2016-03-02 13:47:48 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 14:06:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758663002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758663002/40001
4 years, 9 months ago (2016-03-02 14:17:09 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-02 14:20:25 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 14:20:53 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/879b617b19201c18c0351afb732aab10803da651
Cr-Commit-Position: refs/heads/master@{#34431}

Powered by Google App Engine
This is Rietveld 408576698