Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1758643002: Remove unnecessary code (Closed)

Created:
4 years, 9 months ago by wilson
Modified:
4 years, 9 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M fpdfsdk/src/fsdk_annothandler.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
wilson
Hi lei Plz help to review this CL.
4 years, 9 months ago (2016-03-02 08:18:24 UTC) #2
Tom Sepez
LGTM after fixing nit. https://codereview.chromium.org/1758643002/diff/1/fpdfsdk/src/fsdk_annothandler.cpp File fpdfsdk/src/fsdk_annothandler.cpp (right): https://codereview.chromium.org/1758643002/diff/1/fpdfsdk/src/fsdk_annothandler.cpp#newcode88 fpdfsdk/src/fsdk_annothandler.cpp:88: nit: no blank line here.
4 years, 9 months ago (2016-03-02 20:29:22 UTC) #3
wilson
4 years, 9 months ago (2016-03-03 03:13:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
41c7a97a1b303e43652f40f1b96ab7751783d8ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698