Convert Connect apptest to a unittest

Convert Connect apptest to a unittest

R=sky@chromium.org
BUG=

Committed: https://crrev.com/fe3252084adfdc683503e9c7fff8d2b04863d1d8
Cr-Commit-Position: refs/heads/master@{#378766}

[sky, 2016-03-02 16:10:31]

LGTM

https://codereview.chromium.org/1758633002/diff/40001/mojo/shell/public/cpp/l...
File mojo/shell/public/cpp/lib/shell_test.cc (right):

https://codereview.chromium.org/1758633002/diff/40001/mojo/shell/public/cpp/l...
mojo/shell/public/cpp/lib/shell_test.cc:56:
background_shell_->Init(std::move(params));
I'm pretty sure I made it so you can pass in null if you don't need to set any
params.

https://codereview.chromium.org/1758633002/diff/40001/mojo/shell/public/cpp/s...
File mojo/shell/public/cpp/shell_test.h (right):

https://codereview.chromium.org/1758633002/diff/40001/mojo/shell/public/cpp/s...
mojo/shell/public/cpp/shell_test.h:44: std::string test_name() const { return
initialize_name_; }
nit: const &

[sky, 2016-03-02 16:24:05]

https://codereview.chromium.org/1758633002/diff/40001/mojo/shell/tests/connec...
File mojo/shell/tests/connect/BUILD.gn (right):

https://codereview.chromium.org/1758633002/diff/40001/mojo/shell/tests/connec...
mojo/shell/tests/connect/BUILD.gn:10: test("connect") {
Did you consider including these in mojo_shell_unittests? If you do that you
won't need to update any bots to run these tests.

[Ben Goodger (Google), 2016-03-02 16:52:42]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-03-02 16:52:43]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1758633002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2016-03-02 16:52:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1758633002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1758633002/60001

[Ben Goodger (Google), 2016-03-02 16:53:26]

On 2016/03/02 16:24:05, sky wrote:
>
https://codereview.chromium.org/1758633002/diff/40001/mojo/shell/tests/connec...
> File mojo/shell/tests/connect/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1758633002/diff/40001/mojo/shell/tests/connec...
> mojo/shell/tests/connect/BUILD.gn:10: test("connect") {
> Did you consider including these in mojo_shell_unittests? If you do that you
> won't need to update any bots to run these tests.

Good idea, done.

[sky, 2016-03-02 17:20:23]

SLGTM

[commit-bot: I haz the power, 2016-03-02 17:27:31]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-02 17:28:39]

Description was changed from

==========
Convert Connect apptest to a unittest

R=sky@chromium.org
BUG=
==========

to

==========
Convert Connect apptest to a unittest

R=sky@chromium.org
BUG=

Committed: https://crrev.com/fe3252084adfdc683503e9c7fff8d2b04863d1d8
Cr-Commit-Position: refs/heads/master@{#378766}
==========

[commit-bot: I haz the power, 2016-03-02 17:28:40]

Patchset 4 (id:??) landed as
https://crrev.com/fe3252084adfdc683503e9c7fff8d2b04863d1d8
Cr-Commit-Position: refs/heads/master@{#378766}