Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 1758623002: Revert of [api] Don't go to javascript to construct API functions (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [api] Don't go to javascript to construct API functions (patchset #3 id:40001 of https://codereview.chromium.org/1756433002/ ) Reason for revert: [Sheriff] Breaks webkit unittests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5043 Original issue's description: > [api] Don't go to javascript to construct API functions > > BUG= > R=bmeurer@chromium.org,verwaest@chromium.org > > Committed: https://crrev.com/21a5bfbd2ced6e4a3545bbde712630c0d8734c0b > Cr-Commit-Position: refs/heads/master@{#34411} TBR=bmeurer@chromium.org,verwaest@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/5f8c2b1f1dfd788218d7bfe4b60692d765b12301 Cr-Commit-Position: refs/heads/master@{#34419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -50 lines) Patch
M src/builtins.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/execution.cc View 2 chunks +29 lines, -39 lines 0 comments Download
M src/objects.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [api] Don't go to javascript to construct API functions
4 years, 9 months ago (2016-03-02 07:35:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758623002/1
4 years, 9 months ago (2016-03-02 07:35:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 07:35:37 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 07:36:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f8c2b1f1dfd788218d7bfe4b60692d765b12301
Cr-Commit-Position: refs/heads/master@{#34419}

Powered by Google App Engine
This is Rietveld 408576698