Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/bisector.py

Issue 1758603004: Checking for failure in requested builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect/bisector.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/bisector.py b/scripts/slave/recipe_modules/auto_bisect/bisector.py
index ec12023d8fd828e0b922f907e5b357505a27bd11..fe6d14b0a0531461b43065225cfce3346d87e17e 100644
--- a/scripts/slave/recipe_modules/auto_bisect/bisector.py
+++ b/scripts/slave/recipe_modules/auto_bisect/bisector.py
@@ -654,9 +654,8 @@ class Bisector(object):
self.wait_for(r)
def wait_for(self, revision):
- """Waits for any of the revisions in the list to finish its job(s)."""
+ """Waits for the revision to finish its job."""
with self.api.m.step.nest('Waiting for ' + revision.revision_string()):
- start_time = time.time()
while True:
revision.update_status()
if revision.in_progress:
@@ -665,13 +664,9 @@ class Bisector(object):
"""
import sys
import time
- time.sleep(300)
+ time.sleep(20*60)
sys.exit(0)
""")
- elapsed_time = time.time() - start_time
- if elapsed_time > 3 * 60 * 60: # pragma: no cover
- # Timed out waiting for build
- revision.status = revision.FAILED
else:
break

Powered by Google App Engine
This is Rietveld 408576698