Chromium Code Reviews| Index: chrome/browser/ui/webui/engagement/site_engagement_ui.cc |
| diff --git a/chrome/browser/ui/webui/engagement/site_engagement_ui.cc b/chrome/browser/ui/webui/engagement/site_engagement_ui.cc |
| index 0452cffa2443d8c01e13196e3efd498cb03a313c..c28e8e6c9ff5fd845e7ff314d09cefb2d29b4e10 100644 |
| --- a/chrome/browser/ui/webui/engagement/site_engagement_ui.cc |
| +++ b/chrome/browser/ui/webui/engagement/site_engagement_ui.cc |
| @@ -4,6 +4,7 @@ |
| #include "chrome/browser/ui/webui/engagement/site_engagement_ui.h" |
| +#include <math.h> |
|
Dan Beam
2016/03/11 22:46:36
https://chromium-cpp.appspot.com/ mentions <cmath>
calamity
2016/03/14 05:38:30
Fixed.
|
| #include <utility> |
| #include "base/macros.h" |
| @@ -54,7 +55,7 @@ class SiteEngagementUIHandlerImpl : public SiteEngagementUIHandler { |
| double score) override { |
| GURL origin_gurl(origin.get()); |
| if (!origin_gurl.is_valid() || score < 0 || |
| - score > SiteEngagementScore::kMaxPoints) { |
| + score > SiteEngagementScore::kMaxPoints || isnan(score)) { |
| return; |
| } |
| @@ -78,12 +79,6 @@ SiteEngagementUI::SiteEngagementUI(content::WebUI* web_ui) |
| // Set up the chrome://site-engagement/ source. |
| scoped_ptr<content::WebUIDataSource> source( |
| content::WebUIDataSource::Create(chrome::kChromeUISiteEngagementHost)); |
| - source->AddResourcePath("engagement_table.html", |
| - IDR_SITE_ENGAGEMENT_ENGAGEMENT_TABLE_HTML); |
| - source->AddResourcePath("engagement_table.css", |
| - IDR_SITE_ENGAGEMENT_ENGAGEMENT_TABLE_CSS); |
| - source->AddResourcePath("engagement_table.js", |
| - IDR_SITE_ENGAGEMENT_ENGAGEMENT_TABLE_JS); |
| source->AddResourcePath("site_engagement.js", IDR_SITE_ENGAGEMENT_JS); |
| source->AddResourcePath( |
| "chrome/browser/ui/webui/engagement/site_engagement.mojom", |