Trigger page view event when re-layout is finished

fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp

Index: fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
diff --git a/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp b/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
index f9bf1705546281d54288bce44407398469883306..09c2a14c77d1e8a2896c647c0950cc8abb9d583f 100644
--- a/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
+++ b/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
@@ -27,6 +27,12 @@
 #define FXFA_FORM 0x01000000
 #define FXFA_PDF 0x10000000
 
+#define FXFA_LOADSTATUS_PRELOAD 0

[Tom Sepez, 2016/03/17 00:23:57]

can we make this an enum nested in the class?

[Jim Wang, 2016/03/17 05:00:43]

Done.

+#define FXFA_LOADSTATUS_LOADING 1
+#define FXFA_LOADSTATUS_LOADED 2
+#define FXFA_LOADSTATUS_CLOSING 3
+#define FXFA_LOADSTATUS_CLOSED 4
+
 #ifndef _WIN32
 extern void SetLastError(int err);
 
@@ -41,10 +47,13 @@ CPDFXFA_Document::CPDFXFA_Document(CPDF_Document* pPDFDoc,
       m_pXFADoc(nullptr),
       m_pXFADocView(nullptr),
       m_pApp(pProvider),
-      m_pJSContext(nullptr) {
-}
+      m_pJSContext(nullptr),
+      m_nLoadStatus(FXFA_LOADSTATUS_PRELOAD),
+      m_nPageCount(0) {}
 
 CPDFXFA_Document::~CPDFXFA_Document() {
+  m_nLoadStatus = FXFA_LOADSTATUS_CLOSING;
+
   if (m_pXFADoc) {
     IXFA_App* pApp = m_pApp->GetXFAApp();
     if (pApp) {
@@ -65,9 +74,13 @@ CPDFXFA_Document::~CPDFXFA_Document() {
     else
       delete m_pPDFDoc;
   }
+
+  m_nLoadStatus = FXFA_LOADSTATUS_CLOSED;
 }
 
 FX_BOOL CPDFXFA_Document::LoadXFADoc() {
+  m_nLoadStatus = FXFA_LOADSTATUS_LOADING;
+
   if (!m_pPDFDoc)
     return FALSE;
 
@@ -113,6 +126,8 @@ FX_BOOL CPDFXFA_Document::LoadXFADoc() {
 
   m_pXFADocView->DoLayout(NULL);
   m_pXFADocView->StopLayout();
+  m_nLoadStatus = FXFA_LOADSTATUS_LOADED;
+
   return TRUE;
 }
 
@@ -145,7 +160,8 @@ CPDFXFA_Page* CPDFXFA_Document::GetPage(int page_index) {
     if (pPage)
       pPage->AddRef();
   } else {
-    m_XFAPageList.SetSize(GetPageCount());
+    m_nPageCount = GetPageCount();
+    m_XFAPageList.SetSize(m_nPageCount);
   }
   if (pPage)
     return pPage;
@@ -470,25 +486,39 @@ FX_BOOL CPDFXFA_Document::PopupMenu(IXFA_Widget* hWidget,
 
 void CPDFXFA_Document::PageViewEvent(IXFA_PageView* pPageView,
                                      FX_DWORD dwFlags) {
-  if (!pPageView || (dwFlags != XFA_PAGEVIEWEVENT_PostAdded &&
-                     dwFlags != XFA_PAGEVIEWEVENT_PostRemoved)) {
-    return;
-  }
-  CPDFXFA_Page* pPage = nullptr;
   CPDFDoc_Environment* pEnv = m_pSDKDoc->GetEnv();
-  if (dwFlags == XFA_PAGEVIEWEVENT_PostAdded) {
-    int nPageIndex = pPageView->GetPageViewIndex();
-    pPage = GetPage(nPageIndex);
-    if (pPage)
-      pPage->SetXFAPageView(pPageView);
-    pEnv->FFI_PageEvent(nPageIndex, dwFlags);
+  if (!pEnv)
     return;
+  CPDFXFA_Page* pPage = nullptr;

[Tom Sepez, 2016/03/17 00:23:57]

This gets shadowed at line 505.  We don't need this declaration.

[Jim Wang, 2016/03/17 05:00:43]

Done.

+
+  if (FXFA_LOADSTATUS_LOADING != m_nLoadStatus &&

[Tom Sepez, 2016/03/17 00:23:57]

Nit: prefer m_nLoadStatus != XFA_LOADSTATUS_LOADING

[Jim Wang, 2016/03/17 05:00:43]

Done.

+      FXFA_LOADSTATUS_CLOSING != m_nLoadStatus &&
+      XFA_PAGEVIEWEVENT_StopLayout == dwFlags) {
+    int nNewCount = GetPageCount();
+    if (nNewCount == m_nPageCount)
+      return;
+
+    IXFA_DocView* pXFADocView = GetXFADocView();
+    if (!pXFADocView)
+      return;
+    for (int iPageIter = 0; iPageIter < m_nPageCount; iPageIter++) {
+      CPDFXFA_Page* pPage = m_XFAPageList.GetAt(iPageIter);
+      if (!pPage)
+        continue;
+      m_pSDKDoc->RemovePageView(pPage);
+      IXFA_PageView* pXFAPageView = pXFADocView->GetPageView(iPageIter);
+      pPage->SetXFAPageView(pXFAPageView);
+      if (pXFAPageView)
+        pXFAPageView->LoadPageView(nullptr);
+    }
+
+    int flag = (nNewCount < m_nPageCount) ? FXFA_PAGEVIEWEVENT_POSTREMOVED
+                                          : FXFA_PAGEVIEWEVENT_POSTADDED;
+    int count = FXSYS_abs(nNewCount - m_nPageCount);
+    m_nPageCount = nNewCount;
+    m_XFAPageList.SetSize(nNewCount);
+    pEnv->FFI_PageEvent(count, flag);
   }
-  pPage = GetPage(pPageView);
-  if (!pPage)
-    return;
-  pEnv->FFI_PageEvent(pPage->GetPageIndex(), dwFlags);
-  pPage->Release();
 }
 
 void CPDFXFA_Document::WidgetEvent(IXFA_Widget* hWidget,