Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 175853002: Revert of Add a Restore() method to ValueStore and make StorageAPI use it (Closed)

Created:
6 years, 10 months ago by Devlin
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Add a Restore() method to ValueStore and make StorageAPI use it (https://codereview.chromium.org/165223003/) Reason for revert: Broke win unit_tests with StorageApiUnittest.RestoreStorage Original issue's description: > Add a Restore() method to ValueStore and make StorageAPI use it > Take the first steps in preventing the Storage from getting and staying > corrupted. This lets us Restore() a ValueStore when it's corrputed, and tries to > do so in the StorageAPI calls. > This also refactors so that there's a Local and Sync SettingsBackend - this has > the added advantage of meaning we don't decorate the Local stores with Sync > behavior. > BUG=261623 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252617 TBR=mpcomplete@chromium.org,kalman@chromium.org,joaodasilva@chromium.org NOTREECHECKS=true NOTRY=true BUG=261623 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+430 lines, -1196 lines) Patch
M chrome/browser/extensions/api/storage/leveldb_settings_storage_factory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/storage/leveldb_settings_storage_factory.cc View 1 chunk +1 line, -19 lines 0 comments Download
D chrome/browser/extensions/api/storage/local_storage_backend.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/extensions/api/storage/local_storage_backend.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/browser/extensions/api/storage/policy_value_store.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/storage/policy_value_store.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_backend.h View 1 chunk +75 lines, -29 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_backend.cc View 2 chunks +260 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_frontend.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_quota_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_storage_factory.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.cc View 3 chunks +15 lines, -50 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_sync_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_test_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_test_util.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/storage/storage_api.h View 1 chunk +7 lines, -26 lines 0 comments Download
M chrome/browser/extensions/api/storage/storage_api.cc View 6 chunks +27 lines, -50 lines 0 comments Download
D chrome/browser/extensions/api/storage/storage_api_unittest.cc View 1 chunk +0 lines, -115 lines 0 comments Download
M chrome/browser/extensions/api/storage/sync_or_local_value_store_cache.h View 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/storage/sync_or_local_value_store_cache.cc View 5 chunks +30 lines, -51 lines 0 comments Download
D chrome/browser/extensions/api/storage/sync_storage_backend.h View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/extensions/api/storage/sync_storage_backend.cc View 1 chunk +0 lines, -288 lines 0 comments Download
M chrome/browser/extensions/api/storage/syncable_settings_storage.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/storage/syncable_settings_storage.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/value_store/leveldb_value_store.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/value_store/leveldb_value_store.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M chrome/browser/value_store/leveldb_value_store_unittest.cc View 2 chunks +0 lines, -163 lines 0 comments Download
M chrome/browser/value_store/testing_value_store.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/value_store/testing_value_store.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/value_store/value_store.h View 2 chunks +0 lines, -25 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Devlin
Created Revert of Add a Restore() method to ValueStore and make StorageAPI use it
6 years, 10 months ago (2014-02-21 21:38:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/175853002/1
6 years, 10 months ago (2014-02-21 21:41:21 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 21:44:49 UTC) #3
Message was sent while issue was closed.
Change committed as 252652

Powered by Google App Engine
This is Rietveld 408576698