Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 17585008: Get rid of Isolate::safe_stack_iterator_counter (Closed)

Created:
7 years, 6 months ago by yurys
Modified:
7 years, 6 months ago
Reviewers:
Sven Panne, loislo
CC:
v8-dev, alph
Visibility:
Public.

Description

Get rid of Isolate::safe_stack_iterator_counter This change removes per-isolate counter of active SafeStackFrameIterators. The counter is used by stack frames implementations to avoid accessing pointers to heap objects when traversing stack for CPU profiler (so called "safe" mode). Each StackFrame instance is owned by single iterator and has a pointer to it so we can simply mark the iterator as "safe" or not and read the field in the stack frames instead of going into the isolate. BUG=None R=loislo@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15317

Patch Set 1 #

Patch Set 2 : Updated comment #

Patch Set 3 : Fix debug compilation #

Total comments: 2

Patch Set 4 : Comments addressed #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -53 lines) Patch
M src/frames.h View 1 2 3 6 chunks +12 lines, -22 lines 0 comments Download
M src/frames.cc View 1 2 3 10 chunks +21 lines, -29 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
7 years, 6 months ago (2013-06-25 08:56:12 UTC) #1
loislo
lgtm https://codereview.chromium.org/17585008/diff/4001/src/frames.h File src/frames.h (right): https://codereview.chromium.org/17585008/diff/4001/src/frames.h#newcode819 src/frames.h:819: const bool is_safe_iterator_; I'd call it 'can_use_heap_objects_'
7 years, 6 months ago (2013-06-25 09:36:26 UTC) #2
yurys
https://codereview.chromium.org/17585008/diff/4001/src/frames.h File src/frames.h (right): https://codereview.chromium.org/17585008/diff/4001/src/frames.h#newcode819 src/frames.h:819: const bool is_safe_iterator_; On 2013/06/25 09:36:26, loislo wrote: > ...
7 years, 6 months ago (2013-06-25 09:44:17 UTC) #3
Sven Panne
lgtm
7 years, 6 months ago (2013-06-25 10:00:25 UTC) #4
yurys
7 years, 6 months ago (2013-06-25 10:09:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r15317 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698