third_party/WebKit/Source/platform/inspector_protocol/Values.h - Issue 1758313002: DevTools: introduce collections shim to be backed by non-wtf in v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Values.h

Issue 1758313002: DevTools: introduce collections shim to be backed by non-wtf in v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.h ('k') | third_party/WebKit/Source/platform/inspector_protocol/Values.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/Values.h

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Values.h b/third_party/WebKit/Source/platform/inspector_protocol/Values.h

index 3e4d336f217fe70862673bdd5fcdc6a5fae59df0..8944e9f049ab46e1289092868693555b5cd724ad 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/Values.h

+++ b/third_party/WebKit/Source/platform/inspector_protocol/Values.h

@@ -7,10 +7,8 @@

#include "platform/PlatformExport.h"

#include "platform/inspector_protocol/Allocator.h"

-#include "wtf/HashMap.h"

+#include "platform/inspector_protocol/Collections.h"

#include "wtf/PassOwnPtr.h"

-#include "wtf/TypeTraits.h"

-#include "wtf/Vector.h"

#include "wtf/text/StringHash.h"

#include "wtf/text/WTFString.h"

@@ -178,9 +176,9 @@ public:

private:

DictionaryValue();

- using Dictionary = HashMap<String, OwnPtr<Value>>;

+ using Dictionary = protocol::HashMap<String, OwnPtr<Value>>;

Dictionary m_data;

- Vector<String> m_order;

+ protocol::Vector<String> m_order;

};

class PLATFORM_EXPORT ListValue : public Value {

@@ -214,7 +212,7 @@ public:

private:

ListValue();

- Vector<OwnPtr<Value>> m_data;

+ protocol::Vector<OwnPtr<Value>> m_data;

};

} // namespace protocol