third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp - Issue 1758313002: DevTools: introduce collections shim to be backed by non-wtf in v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp

Issue 1758313002: DevTools: introduce collections shim to be backed by non-wtf in v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.h ('k') | third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.h » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp b/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp

index 678549db72d96d729754f4872023f30c8c5a0f67..e8277ba96d72a5f995b1a24f72397fa3d8e61a8b 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp

@@ -10,7 +10,7 @@

namespace blink {

-v8::Local<v8::FunctionTemplate> InspectorWrapperBase::createWrapperTemplate(v8::Isolate* isolate, const char* className, const Vector<V8MethodConfiguration>& methods, const Vector<V8AttributeConfiguration>& attributes)

+v8::Local<v8::FunctionTemplate> InspectorWrapperBase::createWrapperTemplate(v8::Isolate* isolate, const char* className, const protocol::Vector<V8MethodConfiguration>& methods, const protocol::Vector<V8AttributeConfiguration>& attributes)

{

v8::Local<v8::FunctionTemplate> functionTemplate = v8::FunctionTemplate::New(isolate);