Set Attr.ownerDocument in Element#setAttributeNode()

Source/core/dom/Element.cpp

Index: Source/core/dom/Element.cpp
diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp
index 941c660a172350af91c10c8e51d2f704c79794d4..5f0e0f66fd2929ef2562836ef10785be0b94c6d3 100644
--- a/Source/core/dom/Element.cpp
+++ b/Source/core/dom/Element.cpp
@@ -1809,6 +1809,7 @@ PassRefPtr<Attr> Element::setAttributeNode(Attr* attrNode, ExceptionCode& ec)
     setAttributeInternal(index, attrNode->qualifiedName(), attrNode->value(), NotInSynchronizationOfLazyAttribute);
 
     attrNode->attachToElement(this);
+    treeScope()->adoptIfNeeded(attrNode);

[tkent, 2013/06/24 05:06:37]

This is ok. However, should it be in Attr::attachToElement?

[Hajime Morrita, 2013/06/24 05:24:09]

I thought like that, but turned out that another adoptIfNeeded() call to an Attr
object is done in Element.cpp as well.
So I changed my mind in this way.

[tkent, 2013/06/24 05:26:30]

It makes sense.

     ensureAttrNodeListForElement(this)->append(attrNode);
 
     return oldAttrNode.release();