Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1943)

Unified Diff: device/bluetooth/bluetooth_gatt_characteristic.h

Issue 1758293003: bluetooth: Clarify how StartNotifySession function works (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/bluetooth_gatt_characteristic.h
diff --git a/device/bluetooth/bluetooth_gatt_characteristic.h b/device/bluetooth/bluetooth_gatt_characteristic.h
index 6dabe8714ff3a803af636c7d1ce28d7cda0fedf2..6e7b5fc082700edb3edebea850a6a650da9cdece 100644
--- a/device/bluetooth/bluetooth_gatt_characteristic.h
+++ b/device/bluetooth/bluetooth_gatt_characteristic.h
@@ -181,6 +181,12 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothGattCharacteristic {
// notifications/indications. On success, the characteristic starts sending
// value notifications and |callback| is called with a session object whose
// ownership belongs to the caller. |error_callback| is called on errors.
+ // This function will try to write to the Client Characteristic Configuration
scheib 2016/03/04 01:27:20 blank line above this. "This function will try to
ortuno 2016/03/07 21:58:44 Done.
scheib 2016/03/07 22:18:29 Blank line above this.
ortuno 2016/03/07 22:26:24 Done.
+ // descriptor to enable notifications/indications. According Core Bluetooth
scheib 2016/03/04 01:27:20 remove 'According'
ortuno 2016/03/07 21:58:44 Done.
+ // Specification [V4.2 Vol 3 Part G Section 3.3.1.1.
+ // Characteristic Properties] this descriptor must be present when
scheib 2016/03/04 01:27:20 "this descriptor must be" -> "requires this descri
ortuno 2016/03/07 21:58:44 Done.
+ // notifications/indications is supported. If the descriptor is not present
scheib 2016/03/04 01:27:20 is -> are
ortuno 2016/03/07 21:58:44 Done.
+ // |error_callback| will be ran.
scheib 2016/03/04 01:27:20 ran -> run
ortuno 2016/03/07 21:58:44 Done.
virtual void StartNotifySession(const NotifySessionCallback& callback,
const ErrorCallback& error_callback) = 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698