Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1758293003:
bluetooth: Clarify how StartNotifySession function works (Closed)
|
Created:
4 years, 9 months ago by ortuno Modified:
4 years, 9 months ago Reviewers:
scheib CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@my-origin Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionbluetooth: Clarify how StartNotifySession function works
And what happens when the device doesn't have the expected
descriptor.
BUG=591864
Committed: https://crrev.com/7bc3d0031395dcf700b005c4933102f8897350f6
Cr-Commit-Position: refs/heads/master@{#380538}
Patch Set 1 #
Total comments: 12
Patch Set 2 : Address scheib's comments #Patch Set 3 : Add blank line #Messages
Total messages: 28 (12 generated)
ortuno@chromium.org changed reviewers: + scheib@chromium.org
scheib: PTAL
https://codereview.chromium.org/1758293003/diff/1/device/bluetooth/bluetooth_... File device/bluetooth/bluetooth_gatt_characteristic.h (right): https://codereview.chromium.org/1758293003/diff/1/device/bluetooth/bluetooth_... device/bluetooth/bluetooth_gatt_characteristic.h:184: // This function will try to write to the Client Characteristic Configuration blank line above this. "This function will try to write" -> "Writes" https://codereview.chromium.org/1758293003/diff/1/device/bluetooth/bluetooth_... device/bluetooth/bluetooth_gatt_characteristic.h:185: // descriptor to enable notifications/indications. According Core Bluetooth remove 'According' https://codereview.chromium.org/1758293003/diff/1/device/bluetooth/bluetooth_... device/bluetooth/bluetooth_gatt_characteristic.h:187: // Characteristic Properties] this descriptor must be present when "this descriptor must be" -> "requires this descriptor to be" https://codereview.chromium.org/1758293003/diff/1/device/bluetooth/bluetooth_... device/bluetooth/bluetooth_gatt_characteristic.h:188: // notifications/indications is supported. If the descriptor is not present is -> are https://codereview.chromium.org/1758293003/diff/1/device/bluetooth/bluetooth_... device/bluetooth/bluetooth_gatt_characteristic.h:189: // |error_callback| will be ran. ran -> run
scheib: PTAL again. https://codereview.chromium.org/1758293003/diff/1/device/bluetooth/bluetooth_... File device/bluetooth/bluetooth_gatt_characteristic.h (right): https://codereview.chromium.org/1758293003/diff/1/device/bluetooth/bluetooth_... device/bluetooth/bluetooth_gatt_characteristic.h:184: // This function will try to write to the Client Characteristic Configuration On 2016/03/04 at 01:27:20, scheib wrote: > blank line above this. > "This function will try to write" -> "Writes" Done. https://codereview.chromium.org/1758293003/diff/1/device/bluetooth/bluetooth_... device/bluetooth/bluetooth_gatt_characteristic.h:185: // descriptor to enable notifications/indications. According Core Bluetooth On 2016/03/04 at 01:27:20, scheib wrote: > remove 'According' Done. https://codereview.chromium.org/1758293003/diff/1/device/bluetooth/bluetooth_... device/bluetooth/bluetooth_gatt_characteristic.h:187: // Characteristic Properties] this descriptor must be present when On 2016/03/04 at 01:27:20, scheib wrote: > "this descriptor must be" -> "requires this descriptor to be" Done. https://codereview.chromium.org/1758293003/diff/1/device/bluetooth/bluetooth_... device/bluetooth/bluetooth_gatt_characteristic.h:188: // notifications/indications is supported. If the descriptor is not present On 2016/03/04 at 01:27:20, scheib wrote: > is -> are Done. https://codereview.chromium.org/1758293003/diff/1/device/bluetooth/bluetooth_... device/bluetooth/bluetooth_gatt_characteristic.h:189: // |error_callback| will be ran. On 2016/03/04 at 01:27:20, scheib wrote: > ran -> run Done.
LGTM after: https://codereview.chromium.org/1758293003/diff/1/device/bluetooth/bluetooth_... File device/bluetooth/bluetooth_gatt_characteristic.h (right): https://codereview.chromium.org/1758293003/diff/1/device/bluetooth/bluetooth_... device/bluetooth/bluetooth_gatt_characteristic.h:184: // This function will try to write to the Client Characteristic Configuration On 2016/03/07 21:58:44, ortuno wrote: > On 2016/03/04 at 01:27:20, scheib wrote: > > blank line above this. > > "This function will try to write" -> "Writes" > > Done. Blank line above this.
The CQ bit was checked by ortuno@chromium.org
https://codereview.chromium.org/1758293003/diff/1/device/bluetooth/bluetooth_... File device/bluetooth/bluetooth_gatt_characteristic.h (right): https://codereview.chromium.org/1758293003/diff/1/device/bluetooth/bluetooth_... device/bluetooth/bluetooth_gatt_characteristic.h:184: // This function will try to write to the Client Characteristic Configuration On 2016/03/07 at 22:18:29, scheib wrote: > On 2016/03/07 21:58:44, ortuno wrote: > > On 2016/03/04 at 01:27:20, scheib wrote: > > > blank line above this. > > > "This function will try to write" -> "Writes" > > > > Done. > > Blank line above this. Done.
The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org Link to the patchset: https://codereview.chromium.org/1758293003/#ps40001 (title: "Add blank line")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758293003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758293003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ortuno@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758293003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758293003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ortuno@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758293003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758293003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ortuno@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758293003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758293003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ortuno@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758293003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758293003/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== bluetooth: Clarify how StartNotifySession function works And what happens when the device doesn't have the expected descriptor. BUG=591864 ========== to ========== bluetooth: Clarify how StartNotifySession function works And what happens when the device doesn't have the expected descriptor. BUG=591864 Committed: https://crrev.com/7bc3d0031395dcf700b005c4933102f8897350f6 Cr-Commit-Position: refs/heads/master@{#380538} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/7bc3d0031395dcf700b005c4933102f8897350f6 Cr-Commit-Position: refs/heads/master@{#380538} |
