Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1758283002: PPC: [proxies] throw TypeError if is_callable Map bit is unset (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [proxies] throw TypeError if is_callable Map bit is unset Port 18b9c1ce705e5fe38c23bdd19fcbbfbe3121c611 Original commit message: Per ProxyCreate() (https://tc39.github.io/ecma262/#sec-proxycreate), a Proxy is only given a [[Call]] slot if the target has a [[Call]] slot as well. This was previously implemented correctly for [[Construct]], but not for [[Call]]. R=caitpotter88@gmail.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4797, v8:4796, v8:1543 LOG=N Committed: https://crrev.com/392435bc1458978c28a86f448a7b1eb6717a9ff1 Cr-Commit-Position: refs/heads/master@{#34465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/ppc/builtins-ppc.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
MTBrandyberry
PTAL
4 years, 9 months ago (2016-03-03 16:06:06 UTC) #1
JoranSiu
On 2016/03/03 16:06:06, MTBrandyberry wrote: > PTAL lgtm
4 years, 9 months ago (2016-03-03 17:43:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758283002/1
4 years, 9 months ago (2016-03-03 17:53:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 18:12:06 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 18:12:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/392435bc1458978c28a86f448a7b1eb6717a9ff1
Cr-Commit-Position: refs/heads/master@{#34465}

Powered by Google App Engine
This is Rietveld 408576698