Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: pkg/http_server/test/virtual_directory_test.dart

Issue 17582007: Add support for following links, in VirtualDirectory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Clean up code and tests. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/http_server/lib/src/virtual_directory.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/http_server/test/virtual_directory_test.dart
diff --git a/pkg/http_server/test/virtual_directory_test.dart b/pkg/http_server/test/virtual_directory_test.dart
index d15113b105e4affcab5605a7b8cca1e19a7f19ca..05f8829a8ddd784fe3e0e72fd4956830b3f52dc2 100644
--- a/pkg/http_server/test/virtual_directory_test.dart
+++ b/pkg/http_server/test/virtual_directory_test.dart
@@ -134,5 +134,123 @@ void main() {
});
});
});
+
+ group('links', () {
+ group('follow-links', () {
+ test('dir-link', () {
+ expect(HttpServer.bind('localhost', 0).then((server) {
+ var dir = new Directory('').createTempSync();
+ var dir2 = new Directory('${dir.path}/dir2')..createSync();
+ var link = new Link('${dir.path}/dir3')..createSync('dir2');
+ var file = new File('${dir2.path}/file')..createSync();
+ var virDir = new VirtualDirectory(dir.path);
+ virDir.followLinks = true;
+
+ virDir.serve(server);
+
+ return new HttpClient().get('localhost', server.port, '/dir3/file')
+ .then((request) => request.close())
+ .then((response) => response.drain().then(
+ (_) => response.statusCode))
+ .whenComplete(() {
+ server.close();
+ dir.deleteSync(recursive: true);
+ });
+ }), completion(equals(HttpStatus.OK)));
+ });
+
+ test('root-link', () {
+ expect(HttpServer.bind('localhost', 0).then((server) {
+ var dir = new Directory('').createTempSync();
+ var link = new Link('${dir.path}/dir3')..createSync('.');
+ var file = new File('${dir.path}/file')..createSync();
+ var virDir = new VirtualDirectory(dir.path);
+ virDir.followLinks = true;
+
+ virDir.serve(server);
+
+ return new HttpClient().get('localhost', server.port, '/dir3/file')
+ .then((request) => request.close())
+ .then((response) => response.drain().then(
+ (_) => response.statusCode))
+ .whenComplete(() {
+ server.close();
+ dir.deleteSync(recursive: true);
+ });
+ }), completion(equals(HttpStatus.OK)));
+ });
+
+ group('bad-links', () {
+ test('absolute-link', () {
+ expect(HttpServer.bind('localhost', 0).then((server) {
+ var dir = new Directory('').createTempSync();
+ var file = new File('${dir.path}/file')..createSync();
+ var link = new Link('${dir.path}/dir3')
+ ..createSync('${dir.path}/file');
+ var virDir = new VirtualDirectory(dir.path);
+ virDir.followLinks = true;
+
+ virDir.serve(server);
+
+ return new HttpClient().get('localhost', server.port, '/dir3/file')
+ .then((request) => request.close())
+ .then((response) => response.drain().then(
+ (_) => response.statusCode))
+ .whenComplete(() {
+ server.close();
+ dir.deleteSync(recursive: true);
+ });
+ }), completion(equals(HttpStatus.NOT_FOUND)));
+ });
+
+ test('relative-parent-link', () {
+ expect(HttpServer.bind('localhost', 0).then((server) {
+ var dir = new Directory('').createTempSync();
+ var name = new Path(dir.path).filename;
+ var file = new File('${dir.path}/file')..createSync();
+ var link = new Link('${dir.path}/dir3')
+ ..createSync('../$name/file');
+ var virDir = new VirtualDirectory(dir.path);
+ virDir.followLinks = true;
+
+ virDir.serve(server);
+
+ return new HttpClient().get('localhost', server.port, '/dir3/file')
+ .then((request) => request.close())
+ .then((response) => response.drain().then(
+ (_) => response.statusCode))
+ .whenComplete(() {
+ server.close();
+ dir.deleteSync(recursive: true);
+ });
+ }), completion(equals(HttpStatus.NOT_FOUND)));
+ });
+ });
+ });
+
+ group('not-follow-links', () {
+ test('dir-link', () {
+ expect(HttpServer.bind('localhost', 0).then((server) {
+ var dir = new Directory('').createTempSync();
+ var dir2 = new Directory('${dir.path}/dir2')..createSync();
+ var link = new Link('${dir.path}/dir3')..createSync('dir2');
+ var file = new File('${dir2.path}/file')..createSync();
+ var virDir = new VirtualDirectory(dir.path);
+ virDir.followLinks = false;
+
+ virDir.serve(server);
+
+ return new HttpClient().get('localhost', server.port, '/dir3/file')
+ .then((request) => request.close())
+ .then((response) => response.drain().then(
+ (_) => response.statusCode))
+ .whenComplete(() {
+ server.close();
+ dir.deleteSync(recursive: true);
+ });
+ }), completion(equals(HttpStatus.NOT_FOUND)));
+ });
+ });
+ });
}
« no previous file with comments | « pkg/http_server/lib/src/virtual_directory.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698