Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: runtime/vm/disassembler.cc

Issue 1758153002: Tree-shake consts. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: no closure call bit on icdata anymore either Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/disassembler.cc
diff --git a/runtime/vm/disassembler.cc b/runtime/vm/disassembler.cc
index 1fe421502baa4e293e612eaf35695caaecdcb42a..948c5fe750faaf91e3c0d55bf9b560c9988f0140 100644
--- a/runtime/vm/disassembler.cc
+++ b/runtime/vm/disassembler.cc
@@ -194,6 +194,7 @@ void Disassembler::DisassembleCode(const Function& function, bool optimized) {
code.Disassemble();
THR_Print("}\n");
+#if defined(TARGET_ARCH_IA32)
THR_Print("Pointer offsets for function: {\n");
// Pointer offsets are stored in descending order.
Object& obj = Object::Handle();
@@ -205,6 +206,14 @@ void Disassembler::DisassembleCode(const Function& function, bool optimized) {
}
THR_Print("}\n");
+ ASSERT(ObjectPool::Handle(code.GetObjectPool()).Length() == 0);
+#else
+ ASSERT(code.pointer_offsets_length() == 0);
+
+ const ObjectPool& object_pool = ObjectPool::Handle(code.GetObjectPool());
+ object_pool.DebugPrint();
+#endif
+
THR_Print("PC Descriptors for function '%s' {\n", function_fullname);
PcDescriptors::PrintHeaderString();
const PcDescriptors& descriptors =
@@ -234,9 +243,6 @@ void Disassembler::DisassembleCode(const Function& function, bool optimized) {
THR_Print("}\n");
}
- const ObjectPool& object_pool = ObjectPool::Handle(code.GetObjectPool());
- object_pool.DebugPrint();
-
THR_Print("Stackmaps for function '%s' {\n", function_fullname);
if (code.stackmaps() != Array::null()) {
const Array& stackmap_table = Array::Handle(code.stackmaps());
« no previous file with comments | « no previous file | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698