Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1758153002: Tree-shake consts. (Closed)

Created:
4 years, 9 months ago by rmacnak
Modified:
4 years, 9 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : no closure call bit on icdata anymore either #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -23 lines) Patch
M runtime/vm/disassembler.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M runtime/vm/object.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/precompiler.h View 3 chunks +25 lines, -0 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 2 11 chunks +63 lines, -8 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rmacnak
4 years, 9 months ago (2016-03-04 00:22:49 UTC) #2
Florian Schneider
lgtm https://codereview.chromium.org/1758153002/diff/40001/runtime/vm/precompiler.cc File runtime/vm/precompiler.cc (right): https://codereview.chromium.org/1758153002/diff/40001/runtime/vm/precompiler.cc#newcode1188 runtime/vm/precompiler.cc:1188: for (intptr_t j = 0; j < functions.Length(); ...
4 years, 9 months ago (2016-03-04 00:50:25 UTC) #3
rmacnak
https://codereview.chromium.org/1758153002/diff/40001/runtime/vm/precompiler.cc File runtime/vm/precompiler.cc (right): https://codereview.chromium.org/1758153002/diff/40001/runtime/vm/precompiler.cc#newcode1188 runtime/vm/precompiler.cc:1188: for (intptr_t j = 0; j < functions.Length(); j++) ...
4 years, 9 months ago (2016-03-04 17:33:22 UTC) #5
rmacnak
4 years, 9 months ago (2016-03-04 17:42:58 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
a78ed1c47adde35e946d0149d609c37eacb80988 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698