Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1758113004: cc: ImageDecodes: Move ImageHijackCanvas to a separate file. (Closed)

Created:
4 years, 9 months ago by vmpstr
Modified:
4 years, 9 months ago
Reviewers:
enne (OOO), ericrk
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: ImageDecodes: Move ImageHijackCanvas to a separate file. This patch moves ImageHijackCanvas to a separate file in preparation for overriding SkCanvas instead. This would mean that the canvas has to be plumbed from earlier in the pipeline and having it in a separate file helps. R=enne, ericrk BUG=590859 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/2c9805ca261ad5a791a9abb7ec385884c9c81016 Cr-Commit-Position: refs/heads/master@{#379146}

Patch Set 1 #

Patch Set 2 : disallow_copy_and_assign #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -167 lines) Patch
M cc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/playback/display_list_raster_source.cc View 1 chunk +1 line, -167 lines 0 comments Download
A cc/playback/image_hijack_canvas.h View 1 1 chunk +52 lines, -0 lines 0 comments Download
A cc/playback/image_hijack_canvas.cc View 1 chunk +165 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vmpstr
Please take a look.
4 years, 9 months ago (2016-03-03 22:11:23 UTC) #2
enne (OOO)
lgtm
4 years, 9 months ago (2016-03-03 22:14:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758113004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758113004/20001
4 years, 9 months ago (2016-03-03 22:50:14 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 00:07:49 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 00:08:58 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c9805ca261ad5a791a9abb7ec385884c9c81016
Cr-Commit-Position: refs/heads/master@{#379146}

Powered by Google App Engine
This is Rietveld 408576698