bindings: Makes not call installDOMClassTemplate twice for the same interface.

bindings: Makes not call installDOMClassTemplate twice for the same interface.

If the interface implements partial interfaces, the current implementation
is calling V8DOMConfiguration::installDOMClassTemplate() twice (once for
core/ and the other for modules/).  This implementation is not intuitive,
and we cannot do only-once-things in installDOMClassTemplate().
For example, we cannot call V8DOMConfiguration::setClassString() in
installDOMClassTemplate().

This CL fixes so that we call initializeDOMInterfaceTemplate(), which is
renamed from installDOMClassTemplate(), only once for each interface.

Also separates each section/block with adding empty lines in both of
the template file and generated files.

BUG=

Committed: https://crrev.com/3ee990d9bbf799ee4a81f843e6b1ab71d61883ba
Cr-Commit-Position: refs/heads/master@{#379278}

[Yuki, 2016-03-04 10:45:10]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuki, 2016-03-04 10:45:10]

Could you review this CL?

[haraken, 2016-03-04 10:58:11]

haraken@chromium.org changed reviewers:
+ jochen@chromium.org

[haraken, 2016-03-04 10:58:12]

LGTM

jochen@: FYI see my comment on PS2. Don't need to review this CL :)

https://codereview.chromium.org/1758113003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp (right):

https://codereview.chromium.org/1758113003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp:318: // See
also http://heycam.github.io/webidl/#es-platform-objects

Not related to this CL, but this is worth discussing with jochen@. This means
that once we set a class string on a wrapper, the wrapper is treated as a
"modified" wrapper and thus cannot be collected by a minor GC. This means that
once we set a class string on a wrapper, the minor GC cannot collect any wrapper
(because all wrappers should have the class string).

[Yuki, 2016-03-04 12:36:47]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2016-03-04 12:37:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1758113003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1758113003/20001

[jochen (gone - plz use gerrit), 2016-03-04 12:43:17]

https://codereview.chromium.org/1758113003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp (right):

https://codereview.chromium.org/1758113003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp:318: // See
also http://heycam.github.io/webidl/#es-platform-objects
On 2016/03/04 at 10:58:12, haraken wrote:
> Not related to this CL, but this is worth discussing with jochen@. This means
that once we set a class string on a wrapper, the wrapper is treated as a
"modified" wrapper and thus cannot be collected by a minor GC. This means that
once we set a class string on a wrapper, the minor GC cannot collect any wrapper
(because all wrappers should have the class string).

hum, that's surprising. Setting a string on the instance template shouldn't
cause a map transition from the initial map. Have you verified that this is what
happens?

[commit-bot: I haz the power, 2016-03-04 13:35:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-04 13:36:26]

Description was changed from

==========
bindings: Makes not call installDOMClassTemplate twice for the same interface.

If the interface implements partial interfaces, the current implementation
is calling V8DOMConfiguration::installDOMClassTemplate() twice (once for
core/ and the other for modules/).  This implementation is not intuitive,
and we cannot do only-once-things in installDOMClassTemplate().
For example, we cannot call V8DOMConfiguration::setClassString() in
installDOMClassTemplate().

This CL fixes so that we call initializeDOMInterfaceTemplate(), which is
renamed from installDOMClassTemplate(), only once for each interface.

Also separates each section/block with adding empty lines in both of
the template file and generated files.

BUG=
==========

to

==========
bindings: Makes not call installDOMClassTemplate twice for the same interface.

If the interface implements partial interfaces, the current implementation
is calling V8DOMConfiguration::installDOMClassTemplate() twice (once for
core/ and the other for modules/).  This implementation is not intuitive,
and we cannot do only-once-things in installDOMClassTemplate().
For example, we cannot call V8DOMConfiguration::setClassString() in
installDOMClassTemplate().

This CL fixes so that we call initializeDOMInterfaceTemplate(), which is
renamed from installDOMClassTemplate(), only once for each interface.

Also separates each section/block with adding empty lines in both of
the template file and generated files.

BUG=

Committed: https://crrev.com/3ee990d9bbf799ee4a81f843e6b1ab71d61883ba
Cr-Commit-Position: refs/heads/master@{#379278}
==========

[commit-bot: I haz the power, 2016-03-04 13:36:27]

Patchset 2 (id:??) landed as
https://crrev.com/3ee990d9bbf799ee4a81f843e6b1ab71d61883ba
Cr-Commit-Position: refs/heads/master@{#379278}

[Yuki, 2016-03-04 14:35:40]

https://codereview.chromium.org/1758113003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp (right):

https://codereview.chromium.org/1758113003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp:318: // See
also http://heycam.github.io/webidl/#es-platform-objects
On 2016/03/04 12:43:17, jochen wrote:
> On 2016/03/04 at 10:58:12, haraken wrote:
> > Not related to this CL, but this is worth discussing with jochen@. This
means
> that once we set a class string on a wrapper, the wrapper is treated as a
> "modified" wrapper and thus cannot be collected by a minor GC. This means that
> once we set a class string on a wrapper, the minor GC cannot collect any
wrapper
> (because all wrappers should have the class string).
> 
> hum, that's surprising. Setting a string on the instance template shouldn't
> cause a map transition from the initial map. Have you verified that this is
what
> happens?

I just observe that, if I added
    setClassString(isolate, instanceTemplate, interfaceName);
then, fast/dom/minor-dom-gc.html failed.

How can I verify what's happening?  How can I check if actual instance objects
are marked as "modified" or not?