Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 1758063002: Merge WebUnitTests.cpp into RunAllTests.cpp. (Closed)

Created:
4 years, 9 months ago by jbroman
Modified:
4 years, 9 months ago
Reviewers:
dcheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge WebUnitTests.cpp into RunAllTests.cpp. Blink unit test code is no longer linked into blink_web in component builds: https://chromium.googlesource.com/chromium/src.git/+/737c4d03 Now that these are always both in the webkit_unit_tests binary, there is no need to separate them. Merge them together into a simpler, cohesive RunAllTests.cpp with the same behavior. BUG=590749 Committed: https://crrev.com/7080b7b60fbde15a4b1cb8e61fbce5476c079b82 Cr-Commit-Position: refs/heads/master@{#379006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -145 lines) Patch
M third_party/WebKit/Source/web/tests/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/RunAllTests.cpp View 1 chunk +26 lines, -11 lines 0 comments Download
D third_party/WebKit/Source/web/tests/WebUnitTests.h View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/Source/web/tests/WebUnitTests.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
jbroman
No longer "gloriously complicated"!
4 years, 9 months ago (2016-03-02 21:46:10 UTC) #4
dcheng
Thanks for cleaning this up, this is way nicer! LGTM
4 years, 9 months ago (2016-03-03 06:33:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758063002/1
4 years, 9 months ago (2016-03-03 14:39:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 14:44:39 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 14:45:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7080b7b60fbde15a4b1cb8e61fbce5476c079b82
Cr-Commit-Position: refs/heads/master@{#379006}

Powered by Google App Engine
This is Rietveld 408576698